Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1117373002: fixes #147, add more cases to isStateless (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M lib/runtime/dart/collection.js View 6 chunks +8 lines, -12 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-01 21:31:12 UTC) #2
Jacob
lgtm
5 years, 7 months ago (2015-05-01 21:37:47 UTC) #3
Jennifer Messerly
5 years, 7 months ago (2015-05-05 16:17:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c21c40dd95b4c06429227ebab94686b122decfd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698