Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7065)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 111723012: Linux Aura: Added --use-system-title-bar flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing jamescook nits. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 21f5d84b26f62b14eadaa22900cc3754122fd75d..bdb380516bbb9e40ce32570d6d7825e1f51564cf 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -7,6 +7,7 @@
#include <algorithm>
#include <string>
+#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
@@ -23,6 +24,7 @@
#include "chrome/browser/ui/views/tab_icon_view.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/profile_management_switches.h"
#include "content/public/browser/notification_service.h"
@@ -220,7 +222,7 @@ int OpaqueBrowserFrameView::NonClientHitTest(const gfx::Point& point) {
gfx::Rect sysmenu_rect(IconBounds());
// In maximized mode we extend the rect to the screen corner to take advantage
// of Fitts' Law.
- if (frame()->IsMaximized())
+ if (layout_->IsTitleBarCondensed())
sysmenu_rect.SetRect(0, 0, sysmenu_rect.right(), sysmenu_rect.bottom());
sysmenu_rect.set_x(GetMirroredXForRect(sysmenu_rect));
if (sysmenu_rect.Contains(point))
@@ -259,7 +261,7 @@ void OpaqueBrowserFrameView::GetWindowMask(const gfx::Size& size,
gfx::Path* window_mask) {
DCHECK(window_mask);
- if (frame()->IsMaximized() || frame()->IsFullscreen())
+ if (layout_->IsTitleBarCondensed() || frame()->IsFullscreen())
return;
views::GetDefaultWindowMask(size, window_mask);
@@ -410,11 +412,25 @@ void OpaqueBrowserFrameView::Observe(
// OpaqueBrowserFrameView, OpaqueBrowserFrameViewLayoutDelegate implementation:
bool OpaqueBrowserFrameView::ShouldShowWindowIcon() const {
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+ // If using the system title bar, we do not want to show a second title bar
+ // inside the client area.
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseSystemTitleBar))
+ return false;
+#endif
+
views::WidgetDelegate* delegate = frame()->widget_delegate();
return delegate && delegate->ShouldShowWindowIcon();
}
bool OpaqueBrowserFrameView::ShouldShowWindowTitle() const {
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+ // If using the system title bar, we do not want to show a second title bar
+ // inside the client area.
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseSystemTitleBar))
+ return false;
+#endif
+
// |delegate| may be NULL if called from callback of InputMethodChanged while
// a window is being destroyed.
// See more discussion at http://crosbug.com/8958
@@ -505,7 +521,7 @@ void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
if (frame()->IsFullscreen())
return; // Nothing is visible, so don't bother to paint.
- if (frame()->IsMaximized())
+ if (layout_->IsTitleBarCondensed())
PaintMaximizedFrameBorder(canvas);
else
PaintRestoredFrameBorder(canvas);
@@ -520,7 +536,7 @@ void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
if (browser_view()->IsToolbarVisible())
PaintToolbarBackground(canvas);
- if (!frame()->IsMaximized())
+ if (!layout_->IsTitleBarCondensed())
PaintRestoredClientEdge(canvas);
}

Powered by Google App Engine
This is Rietveld 408576698