Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: chrome/browser/net/certificate_error_reporter_unittest.cc

Issue 1117173005: Include cert status in invalid certificate reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/certificate_error_reporter_unittest.cc
diff --git a/chrome/browser/net/certificate_error_reporter_unittest.cc b/chrome/browser/net/certificate_error_reporter_unittest.cc
index f9054cd5cd054e625f6f477657b97bf6660bb88d..309894864dbaf676e3bf5dc603a13ddaef866f87 100644
--- a/chrome/browser/net/certificate_error_reporter_unittest.cc
+++ b/chrome/browser/net/certificate_error_reporter_unittest.cc
@@ -26,6 +26,7 @@
#include "net/base/upload_bytes_element_reader.h"
#include "net/base/upload_data_stream.h"
#include "net/base/upload_element_reader.h"
+#include "net/cert/cert_status_flags.h"
#include "net/test/cert_test_util.h"
#include "net/test/url_request/url_request_failed_job.h"
#include "net/test/url_request/url_request_mock_data_job.h"
@@ -36,6 +37,7 @@
using chrome_browser_net::CertificateErrorReporter;
using content::BrowserThread;
+using net::CertStatus;
using net::CompletionCallback;
using net::SSLInfo;
using net::NetworkDelegateImpl;
@@ -49,12 +51,14 @@ const char kSecondRequestHostname[] = "test2.mail.google.com";
const char kDummyFailureLog[] = "dummy failure log";
const char kTestCertFilename[] = "test_mail_google_com.pem";
const uint32 kServerPublicKeyVersion = 1;
+const CertStatus kCertStatus = net::CERT_STATUS_COMMON_NAME_INVALID;
SSLInfo GetTestSSLInfo() {
SSLInfo info;
info.cert =
net::ImportCertFromFile(net::GetTestCertsDirectory(), kTestCertFilename);
info.is_issued_by_known_root = true;
+ info.cert_status = kCertStatus;
info.pinning_failure_log = kDummyFailureLog;
return info;
}
@@ -125,6 +129,7 @@ void CheckUploadData(URLRequest* request,
EXPECT_EQ(GetPEMEncodedChain(), uploaded_request.cert_chain());
EXPECT_EQ(1, uploaded_request.pin().size());
EXPECT_EQ(kDummyFailureLog, uploaded_request.pin().Get(0));
+ EXPECT_EQ(kCertStatus, uploaded_request.cert_status());
}
// A network delegate that lets tests check that a certificate error
« chrome/browser/net/cert_logger.proto ('K') | « chrome/browser/net/certificate_error_reporter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698