Split cert reporter class into report building/serializing and sending

chrome/browser/net/certificate_error_reporter.h

Index: chrome/browser/net/certificate_error_reporter.h
diff --git a/chrome/browser/net/certificate_error_reporter.h b/chrome/browser/net/certificate_error_reporter.h
index cba431f640e49960fc011f0393ccef4bfb300bdd..bf16607c0a259cc785a4bcf3a5ee18de49bc5197 100644
--- a/chrome/browser/net/certificate_error_reporter.h
+++ b/chrome/browser/net/certificate_error_reporter.h
@@ -20,7 +20,6 @@ class SSLInfo;
 
 namespace chrome_browser_net {
 
-class CertLoggerRequest;
 class EncryptedCertLoggerRequest;
 
 // Provides functionality for sending reports about invalid SSL
@@ -72,8 +71,7 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
   // unsupported platforms, callers must send extended reporting reports
   // over SSL.
   virtual void SendReport(ReportType type,
-                          const std::string& hostname,
-                          const net::SSLInfo& ssl_info);
+                          const std::string& serialized_report);

[eroman, 2015/05/12 00:27:51]

Please add some description of what serialized_report contains (data contents,
as well as the format). It doesn't need to be fully specified, but there should
be some general pointers to its value.

[estark, 2015/05/12 20:42:15]

Done.

 
   // net::URLRequest::Delegate
   void OnResponseStarted(net::URLRequest* request) override;
@@ -87,7 +85,7 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
   static bool DecryptCertificateErrorReport(
       const uint8 server_private_key[32],
       const EncryptedCertLoggerRequest& encrypted_report,
-      CertLoggerRequest* decrypted_report);
+      std::string* decrypted_serialized_report);
 
  private:
   // Create a URLRequest with which to send a certificate report to the
@@ -95,17 +93,10 @@ class CertificateErrorReporter : public net::URLRequest::Delegate {
   virtual scoped_ptr<net::URLRequest> CreateURLRequest(
       net::URLRequestContext* context);
 
-  // Serialize and send a CertLoggerRequest protobuf to the report
+  // Send a serialized report (encrypted or not) to the report

[eroman, 2015/05/12 00:27:51]

nit: All of these comments should be descriptive "Sends a serialized ..." rather
than imperative "Send a serialized". See
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Com...

[estark, 2015/05/12 20:42:16]

Done.

   // collection server.
-  void SendCertLoggerRequest(const CertLoggerRequest& request);
-
   void SendSerializedRequest(const std::string& serialized_request);
 
-  // Populate the CertLoggerRequest for a report.
-  static void BuildReport(const std::string& hostname,
-                          const net::SSLInfo& ssl_info,
-                          CertLoggerRequest* out_request);
-
   // Performs post-report cleanup.
   void RequestComplete(net::URLRequest* request);