Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 1117173004: Split cert reporter class into report building/serializing and sending (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move //c/b/ssl classes into global namespace Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index b50e3e3c5c6bb2ea5874e7b23b1a0f4d7e8e1094..db59f3b94d3390dc9db8d2f399fadc10b969cb37 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -215,15 +215,14 @@ void SafeBrowsingUIManager::ReportSafeBrowsingHit(
}
void SafeBrowsingUIManager::ReportInvalidCertificateChain(
- const std::string& hostname,
- const net::SSLInfo& ssl_info,
+ const std::string& serialized_report,
const base::Closure& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTaskAndReply(
BrowserThread::IO, FROM_HERE,
base::Bind(
&SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread, this,
- hostname, ssl_info),
+ serialized_report),
callback);
}
@@ -261,8 +260,7 @@ void SafeBrowsingUIManager::ReportSafeBrowsingHitOnIOThread(
}
void SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread(
- const std::string& hostname,
- const net::SSLInfo& ssl_info) {
+ const std::string& serialized_report) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// The service may delete the ping manager (i.e. when user disabling service,
@@ -270,8 +268,7 @@ void SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread(
if (!sb_service_ || !sb_service_->ping_manager())
return;
- sb_service_->ping_manager()->ReportInvalidCertificateChain(hostname,
- ssl_info);
+ sb_service_->ping_manager()->ReportInvalidCertificateChain(serialized_report);
}
// If the user had opted-in to send MalwareDetails, this gets called

Powered by Google App Engine
This is Rietveld 408576698