Split cert reporter class into report building/serializing and sending

chrome/browser/ssl/ssl_blocking_page.cc

Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 46ad971efae26dd6142ab724d1af302275e9c338..1dbe44512441575e05858acb31e24c66dfb4e02d 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -28,6 +28,7 @@
 #include "chrome/browser/interstitials/security_interstitial_metrics_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_preferences_util.h"
+#include "chrome/browser/ssl/certificate_error_report.h"
 #include "chrome/browser/ssl/ssl_cert_reporter.h"
 #include "chrome/browser/ssl/ssl_error_classification.h"
 #include "chrome/browser/ssl/ssl_error_info.h"
@@ -75,6 +76,7 @@
 
 using base::ASCIIToUTF16;
 using base::TimeTicks;
+using chrome_browser_ssl::CertificateErrorReport;
 using content::InterstitialPage;
 using content::InterstitialPageDelegate;
 using content::NavigationController;
@@ -663,8 +665,13 @@ void SSLBlockingPage::FinishCertCollection() {
       SecurityInterstitialMetricsHelper::EXTENDED_REPORTING_IS_ENABLED);
 
   if (ShouldReportCertificateError()) {
-    ssl_cert_reporter_->ReportInvalidCertificateChain(request_url().host(),
-                                                      ssl_info_);
+    std::string serialized_report;
+    CertificateErrorReport report(request_url().host(), ssl_info_);
+    if (report.Serialize(&serialized_report)) {
+      ssl_cert_reporter_->ReportInvalidCertificateChain(serialized_report);
+    } else {
+      LOG(ERROR) << "Failed to serialize certificate report.";
+    }

[Ryan Sleevi, 2015/05/13 01:02:13]

ditto earlier remarks about error handling

[estark, 2015/05/13 01:44:49]

Done.

   }
 }