Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: chrome/browser/ssl/chrome_fraudulent_certificate_reporter.h

Issue 1117173004: Split cert reporter class into report building/serializing and sending (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: document parse/serialize return value Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_fraudulent_certificate_reporter.h
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h b/chrome/browser/ssl/chrome_fraudulent_certificate_reporter.h
similarity index 62%
rename from chrome/browser/net/chrome_fraudulent_certificate_reporter.h
rename to chrome/browser/ssl/chrome_fraudulent_certificate_reporter.h
index 86575eaaa2540aa4b39f969c1a5eb0d30e06cd61..d79c3d7691b2df25b05aa60b09658fb2fcb14feb 100644
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
+++ b/chrome/browser/ssl/chrome_fraudulent_certificate_reporter.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
-#define CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
+#ifndef CHROME_BROWSER_SSL_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
+#define CHROME_BROWSER_SSL_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
#include <set>
#include <string>
@@ -11,13 +11,15 @@
#include "base/memory/scoped_ptr.h"
#include "net/url_request/fraudulent_certificate_reporter.h"
+namespace chrome_browser_net {
+class CertificateErrorReporter;
+} // namespace chrome_browser_net
+
namespace net {
class URLRequestContext;
-}
+} // namespace net
-namespace chrome_browser_net {
-
-class CertificateErrorReporter;
+namespace chrome_browser_ssl {
class ChromeFraudulentCertificateReporter
: public net::FraudulentCertificateReporter {
@@ -26,8 +28,8 @@ class ChromeFraudulentCertificateReporter
net::URLRequestContext* request_context);
// Useful for tests to use a mock reporter.
- explicit ChromeFraudulentCertificateReporter(
- scoped_ptr<CertificateErrorReporter> certificate_reporter);
+ explicit ChromeFraudulentCertificateReporter(scoped_ptr<
+ chrome_browser_net::CertificateErrorReporter> certificate_reporter);
~ChromeFraudulentCertificateReporter() override;
@@ -36,11 +38,12 @@ class ChromeFraudulentCertificateReporter
const net::SSLInfo& ssl_info) override;
private:
- scoped_ptr<CertificateErrorReporter> certificate_reporter_;
+ scoped_ptr<chrome_browser_net::CertificateErrorReporter>
+ certificate_reporter_;
DISALLOW_COPY_AND_ASSIGN(ChromeFraudulentCertificateReporter);
};
-} // namespace chrome_browser_net
+} // namespace chrome_browser_ssl
-#endif // CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
+#endif // CHROME_BROWSER_SSL_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_

Powered by Google App Engine
This is Rietveld 408576698