Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/net/certificate_error_reporter.h

Issue 1117173004: Split cert reporter class into report building/serializing and sending (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move //c/b/ssl classes into global namespace Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_ 5 #ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
6 #define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_ 6 #define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "net/url_request/url_request.h" 13 #include "net/url_request/url_request.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 namespace net { 16 namespace net {
17 class URLRequestContext; 17 class URLRequestContext;
18 class SSLInfo; 18 class SSLInfo;
19 } 19 }
20 20
21 namespace chrome_browser_net { 21 namespace chrome_browser_net {
22 22
23 class CertLoggerRequest;
24 class EncryptedCertLoggerRequest; 23 class EncryptedCertLoggerRequest;
25 24
26 // Provides functionality for sending reports about invalid SSL 25 // Provides functionality for sending reports about invalid SSL
27 // certificate chains to a report collection server. 26 // certificate chains to a report collection server.
28 class CertificateErrorReporter : public net::URLRequest::Delegate { 27 class CertificateErrorReporter : public net::URLRequest::Delegate {
29 public: 28 public:
30 // These represent the types of reports that can be sent. 29 // These represent the types of reports that can be sent.
31 enum ReportType { 30 enum ReportType {
32 // A report of a certificate chain that failed a certificate pinning 31 // A report of a certificate chain that failed a certificate pinning
33 // check. 32 // check.
34 REPORT_TYPE_PINNING_VIOLATION, 33 REPORT_TYPE_PINNING_VIOLATION,
35 // A report for an invalid certificate chain that is being sent for 34 // A report for an invalid certificate chain that is being sent for
36 // a user who has opted-in to the extended reporting program. 35 // a user who has opted-in to the extended reporting program.
37 REPORT_TYPE_EXTENDED_REPORTING 36 REPORT_TYPE_EXTENDED_REPORTING
38 }; 37 };
39 38
40 // Represents whether or not to send cookies along with reports sent 39 // Represents whether or not to send cookies along with reports sent
41 // to the server. 40 // to the server.
42 enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES }; 41 enum CookiesPreference { SEND_COOKIES, DO_NOT_SEND_COOKIES };
43 42
44 // Create a certificate error reporter that will send certificate 43 // Creates a certificate error reporter that will send certificate
45 // error reports to |upload_url|, using |request_context| as the 44 // error reports to |upload_url|, using |request_context| as the
46 // context for the reports. |cookies_preference| controls whether 45 // context for the reports. |cookies_preference| controls whether
47 // cookies will be sent along with the reports. 46 // cookies will be sent along with the reports.
48 CertificateErrorReporter(net::URLRequestContext* request_context, 47 CertificateErrorReporter(net::URLRequestContext* request_context,
49 const GURL& upload_url, 48 const GURL& upload_url,
50 CookiesPreference cookies_preference); 49 CookiesPreference cookies_preference);
51 50
52 // Allows tests to use a server public key with known private key. 51 // Allows tests to use a server public key with known private key.
53 CertificateErrorReporter(net::URLRequestContext* request_context, 52 CertificateErrorReporter(net::URLRequestContext* request_context,
54 const GURL& upload_url, 53 const GURL& upload_url,
55 CookiesPreference cookies_preference, 54 CookiesPreference cookies_preference,
56 const uint8 server_public_key[32], 55 const uint8 server_public_key[32],
57 const uint32 server_public_key_version); 56 const uint32 server_public_key_version);
58 57
59 ~CertificateErrorReporter() override; 58 ~CertificateErrorReporter() override;
60 59
61 // Construct, serialize, and send a certificate report to the report 60 // Sends a certificate report to the report collection server. The
62 // collection server containing the |ssl_info| associated with a 61 // |serialized_report| is expected to be a serialized protobuf
63 // connection to |hostname|. 62 // containing information about the hostname, certificate chain, and
63 // certificate errors encountered when validating the chain.
64 // 64 //
65 // SendReport actually sends the report over the network; callers are 65 // |SendReport| actually sends the report over the network; callers are
66 // responsible for enforcing any preconditions (such as obtaining user 66 // responsible for enforcing any preconditions (such as obtaining user
67 // opt-in, only sending reports for certain hostnames, checking for 67 // opt-in, only sending reports for certain hostnames, checking for
68 // incognito mode, etc.). 68 // incognito mode, etc.).
69 // 69 //
70 // On some platforms (but not all), CertificateErrorReporter can use 70 // On some platforms (but not all), CertificateErrorReporter can use
71 // an HTTP endpoint to send encrypted extended reporting reports. On 71 // an HTTP endpoint to send encrypted extended reporting reports. On
72 // unsupported platforms, callers must send extended reporting reports 72 // unsupported platforms, callers must send extended reporting reports
73 // over SSL. 73 // over SSL.
74 virtual void SendReport(ReportType type, 74 virtual void SendReport(ReportType type,
75 const std::string& hostname, 75 const std::string& serialized_report);
76 const net::SSLInfo& ssl_info);
77 76
78 // net::URLRequest::Delegate 77 // net::URLRequest::Delegate
79 void OnResponseStarted(net::URLRequest* request) override; 78 void OnResponseStarted(net::URLRequest* request) override;
80 void OnReadCompleted(net::URLRequest* request, int bytes_read) override; 79 void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
81 80
82 // Callers can use this method to determine if sending reports over 81 // Callers can use this method to determine if sending reports over
83 // HTTP is supported. 82 // HTTP is supported.
84 static bool IsHttpUploadUrlSupported(); 83 static bool IsHttpUploadUrlSupported();
85 84
86 // Used by tests. 85 // Used by tests.
87 static bool DecryptCertificateErrorReport( 86 static bool DecryptCertificateErrorReport(
88 const uint8 server_private_key[32], 87 const uint8 server_private_key[32],
89 const EncryptedCertLoggerRequest& encrypted_report, 88 const EncryptedCertLoggerRequest& encrypted_report,
90 CertLoggerRequest* decrypted_report); 89 std::string* decrypted_serialized_report);
91 90
92 private: 91 private:
93 // Create a URLRequest with which to send a certificate report to the 92 // Creates a URLRequest with which to send a certificate report to the
94 // server. 93 // server.
95 virtual scoped_ptr<net::URLRequest> CreateURLRequest( 94 virtual scoped_ptr<net::URLRequest> CreateURLRequest(
96 net::URLRequestContext* context); 95 net::URLRequestContext* context);
97 96
98 // Serialize and send a CertLoggerRequest protobuf to the report 97 // Sends a serialized report (encrypted or not) to the report
99 // collection server. 98 // collection server.
100 void SendCertLoggerRequest(const CertLoggerRequest& request);
101
102 void SendSerializedRequest(const std::string& serialized_request); 99 void SendSerializedRequest(const std::string& serialized_request);
103 100
104 // Populate the CertLoggerRequest for a report.
105 static void BuildReport(const std::string& hostname,
106 const net::SSLInfo& ssl_info,
107 CertLoggerRequest* out_request);
108
109 // Performs post-report cleanup. 101 // Performs post-report cleanup.
110 void RequestComplete(net::URLRequest* request); 102 void RequestComplete(net::URLRequest* request);
111 103
112 net::URLRequestContext* const request_context_; 104 net::URLRequestContext* const request_context_;
113 const GURL upload_url_; 105 const GURL upload_url_;
114 106
115 // Owns the contained requests. 107 // Owns the contained requests.
116 std::set<net::URLRequest*> inflight_requests_; 108 std::set<net::URLRequest*> inflight_requests_;
117 109
118 CookiesPreference cookies_preference_; 110 CookiesPreference cookies_preference_;
119 111
120 const uint8* server_public_key_; 112 const uint8* server_public_key_;
121 const uint32 server_public_key_version_; 113 const uint32 server_public_key_version_;
122 114
123 DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter); 115 DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
124 }; 116 };
125 117
126 } // namespace chrome_browser_net 118 } // namespace chrome_browser_net
127 119
128 #endif // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_ 120 #endif // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698