Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/ssl/certificate_error_report.h

Issue 1117173004: Split cert reporter class into report building/serializing and sending (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: error handling first Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ssl/cert_logger.proto ('k') | chrome/browser/ssl/certificate_error_report.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_SSL_CERTIFICATE_ERROR_REPORT_H_
6 #define CHROME_BROWSER_SSL_CERTIFICATE_ERROR_REPORT_H_
7
8 #include <string>
9
10 #include "base/memory/scoped_ptr.h"
11
12 namespace net {
13 class SSLInfo;
14 } // namespace net
15
16 namespace chrome_browser_ssl {
mmenke 2015/05/13 15:02:05 I defer to others, but I think the consensus now i
estark 2015/05/13 17:40:38 Ah, so instead we'd just put CertificateErrorRepor
mmenke 2015/05/13 18:03:01 Correct. That's what most things do. I can't fin
estark 2015/05/13 20:38:43 Done.
17
18 class CertLoggerRequest;
19
20 // This class builds and serializes reports for invalid SSL certificate
21 // chains, intended to be sent with
22 // chrome_browser_net::CertificateErrorReporter.
23 class CertificateErrorReport {
24 public:
25 // Constructs an empty report.
26 CertificateErrorReport();
27
28 // Constructs a report for the given |hostname| using the SSL
29 // properties in |ssl_info|.
30 CertificateErrorReport(const std::string& hostname,
31 const net::SSLInfo& ssl_info);
32
33 ~CertificateErrorReport();
34
35 // Initializes an empty report by parsing the given serialized
36 // report. |serialized_report| should be a serialized
37 // CertLoggerRequest protobuf. Returns true if the report could be
38 // successfully parsed and false otherwise.
39 bool InitializeFromString(const std::string& serialized_report);
40
41 // Serializes the report. The output will be a serialized
42 // CertLoggerRequest protobuf. Returns true if the serialization was
43 // successful and false otherwise.
44 bool Serialize(std::string* output) const;
45
46 // Gets the hostname to which this report corresponds.
47 const std::string& hostname() const;
48
49 private:
50 scoped_ptr<CertLoggerRequest> cert_report_;
51 };
52
53 } // namespace chrome_browser_ssl
54
55 #endif // CHROME_BROWSER_SSL_CERTIFICATE_ERROR_REPORT_H_
OLDNEW
« no previous file with comments | « chrome/browser/ssl/cert_logger.proto ('k') | chrome/browser/ssl/certificate_error_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698