Split cert reporter class into report building/serializing and sending

chrome/browser/ssl/certificate_error_report.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SSL_CERTIFICATE_ERROR_REPORT_H_
+#define CHROME_BROWSER_SSL_CERTIFICATE_ERROR_REPORT_H_
+
+#include <string>
+
+#include "chrome/browser/ssl/cert_logger.pb.h"

[Ryan Sleevi, 2015/05/13 01:02:12]

In general, including .pb.h in header files is a recipe for non-deterministic
build disasters due to transitive cross-target dependencies.

I... don't have a good summary of the issue... but could point at countless
build breaks due to protobuf & export_dependent_setting issues. Even GN hasn't
quite solved this so much as "danced around it".

To the extent possible, I would discourage you from putting this header in,
which likely means not making the CertLoggerRequest a member (or making it a
pointer member). Either are somewhat icky.

[estark, 2015/05/13 01:44:49]

Good to know; I changed it to be a pointer member.

+
+namespace net {
+class SSLInfo;
+};  // namespace net

[Ryan Sleevi, 2015/05/13 01:02:12]

no ;

[estark, 2015/05/13 01:44:49]

Done.

+
+namespace chrome_browser_ssl {
+
+class CertLoggerRequest;

[Ryan Sleevi, 2015/05/13 01:02:12]

You can't forward declare this, because line 50 needs to allocate storage.

[estark, 2015/05/13 01:44:49]

Changed line 50 to be a scoped_ptr

+
+// This class builds and serializes reports for invalid SSL certificate
+// chains, intended to be sent with
+// chrome_browser_net::CertificateErrorReporter.
+class CertificateErrorReport {
+ public:
+  // Constructs an empty report.
+  CertificateErrorReport();
+
+  // Constructs a report for the given |hostname| using the SSL
+  // properties in |ssl_info|.
+  CertificateErrorReport(const std::string& hostname,
+                         const net::SSLInfo& ssl_info);
+
+  ~CertificateErrorReport();
+
+  // Initializes an empty report by parsing the given serialized
+  // report. |serialized_report| should be a serialized
+  // CertLoggerRequest protobuf. Returns true if the report could be
+  // successfully parsed and false otherwise.
+  bool InitializeFromString(const std::string& serialized_report);
+
+  // Serializes the report. The output will be a serialized
+  // CertLoggerRequest protobuf. Returns true if the serialization was
+  // successful and false otherwise.
+  bool Serialize(std::string* output) const;
+
+  // Gets the hostname to which this report corresponds.
+  const std::string& hostname() const;
+
+ private:
+  CertLoggerRequest cert_report_;
+};
+
+}  // namespace chrome_browser_ssl
+
+#endif  // CHROME_BROWSER_SSL_CERTIFICATE_ERROR_REPORT_H_