Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 1117173003: Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a test case for ignoring synthesized mouse events. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/event_rewriter.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc
index e35bdae02167a4ab76b4199fbcddabd19912adb7..015502d240ca2cde5d1b5d685c8ceb4fbe9f7b3c 100644
--- a/chrome/browser/chromeos/events/event_rewriter.cc
+++ b/chrome/browser/chromeos/events/event_rewriter.cc
@@ -890,12 +890,13 @@ void EventRewriter::RewriteLocatedEvent(const ui::Event& event,
int EventRewriter::RewriteModifierClick(const ui::MouseEvent& mouse_event,
int* flags) {
- // Remap Alt+Button1 to Button3.
- const int kAltLeftButton = (ui::EF_ALT_DOWN | ui::EF_LEFT_MOUSE_BUTTON);
- if (((*flags & kAltLeftButton) == kAltLeftButton) &&
+ // Remap Search+Button1 to Button3.
+ const int kSearchLeftButton =
+ (ui::EF_COMMAND_DOWN | ui::EF_LEFT_MOUSE_BUTTON);
+ if (((*flags & kSearchLeftButton) == kSearchLeftButton) &&
((mouse_event.type() == ui::ET_MOUSE_PRESSED) ||
pressed_device_ids_.count(mouse_event.source_device_id()))) {
- *flags &= ~kAltLeftButton;
+ *flags &= ~kSearchLeftButton;
*flags |= ui::EF_RIGHT_MOUSE_BUTTON;
if (mouse_event.type() == ui::ET_MOUSE_PRESSED)
pressed_device_ids_.insert(mouse_event.source_device_id());
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.h ('k') | chrome/browser/chromeos/events/event_rewriter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698