ui/base/accelerators/accelerator_history.h - Issue 1117173003: Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/accelerators/accelerator_history.h

Issue 1117173003: Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a test, and addressed comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/accelerators/accelerator_filter_unittest.cc ('K') | « chrome/browser/chromeos/events/event_rewriter_unittest.cc ('k') | ui/wm/core/accelerator_filter.h » ('j') | ui/wm/core/accelerator_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/base/accelerators/accelerator_history.h

diff --git a/ui/base/accelerators/accelerator_history.h b/ui/base/accelerators/accelerator_history.h

index 435e75274f22571084f9103bf4b30b76370a44ee..4b0f51acc5a3333caf56692843ce780a298bd706 100644

--- a/ui/base/accelerators/accelerator_history.h

+++ b/ui/base/accelerators/accelerator_history.h

@@ -25,8 +25,9 @@ class UI_BASE_EXPORT AcceleratorHistory {

return current_accelerator_;

}

- // Returns the most recent previously recorded accelerator that is different

- // than the current.

+ // Returns the most recent previously recorded key accelerator that is

+ // different than the current. Non-synthesized mouse events will be stored

+ // in the histroy as an empty accelerator.

const Accelerator& previous_accelerator() const {

return previous_accelerator_;

}