Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick)

ash/accelerators/accelerator_filter_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/wm/core/accelerator_filter.h"
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 116 matching lines @@
   // System keys pass through to a child window if the parent (top level)
   // window has the property set.
   scoped_ptr<aura::Window> child(CreateTestWindowInShellWithId(2));
   window->AddChild(child.get());
   dispatch_helper.set_target(child.get());
   filter.OnKeyEvent(&press_volume_up);
   EXPECT_FALSE(press_volume_up.stopped_propagation());
 }
 #endif  // defined(OS_CHROMEOS)
 
+// Tests that pressing 'SEARCH' + LeftMouseClick, which will be rewritten as a
+// RightMouseClick, will not toggle the AppList.
+// This test will fail without the code to clear the current accelerator in
+// the accelerator history present in |AcceleratorFilter::OnMouseEvent()|.
+TEST_F(AcceleratorFilterTest, SearchClickDoesntToggleAppList) {
+  ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
+
+  EXPECT_FALSE(ash::Shell::GetInstance()->GetAppListTargetVisibility());
+  generator.PressKey(ui::VKEY_LWIN, 0);
+  generator.PressLeftButton();
+  generator.ReleaseLeftButton();

[sadrul, 2015/05/04 17:16:17]

ClickLeftButton() instead of Press/Release?

[afakhry, 2015/05/04 20:17:08]

Done.

+  generator.ReleaseKey(ui::VKEY_LWIN, 0);
+  EXPECT_FALSE(ash::Shell::GetInstance()->GetAppListTargetVisibility());

[sadrul, 2015/05/04 17:16:17]

If you leave the synth. bit in AcceleratorFilter, can you update this test to
add a case where generating a synth mouse-event doesn't reset the state?

[afakhry, 2015/05/04 20:17:08]

Done.

+}
+
 }  // namespace test
 }  // namespace ash