Clang style plugin: add warn-only option and use it on Windows

tools/clang/plugins/FindBadConstructsConsumer.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "FindBadConstructsConsumer.h"
 
 #include "clang/Frontend/CompilerInstance.h"
 #include "clang/AST/Attr.h"
 #include "clang/Lex/Lexer.h"
 #include "llvm/Support/raw_ostream.h"
@@ skipping 83 matching lines @@
   return record.isPOD() ||
          record.getDescribedClassTemplate() ||
          record.getTemplateSpecializationKind() ||
          record.isDependentType();
 }
 
 }  // namespace
 
 FindBadConstructsConsumer::FindBadConstructsConsumer(CompilerInstance& instance,
                                                      const Options& options)
-    : ChromeClassTester(instance), options_(options) {
+    : ChromeClassTester(instance, options) {
   // Messages for virtual method specifiers.
   diag_method_requires_override_ =
       diagnostic().getCustomDiagID(getErrorLevel(), kMethodRequiresOverride);
   diag_redundant_virtual_specifier_ =
       diagnostic().getCustomDiagID(getErrorLevel(), kRedundantVirtualSpecifier);
   diag_base_method_virtual_and_final_ =
       diagnostic().getCustomDiagID(getErrorLevel(), kBaseMethodVirtualAndFinal);
 
   // Messages for destructors.
   diag_no_explicit_dtor_ =
@@ skipping 471 matching lines @@
   if (CXXDestructorDecl* dtor = record->getDestructor()) {
     if (dtor->getAccess() == AS_public) {
       loc = dtor->getInnerLocStart();
       return PublicDestructor;
     }
   }
 
   return None;
 }
 
-// Adds either a warning or error, based on the current handling of
-// -Werror.
-DiagnosticsEngine::Level FindBadConstructsConsumer::getErrorLevel() {
-#if defined(LLVM_ON_WIN32)
-  // TODO(dcheng): Re-enable -Werror for these diagnostics on Windows once all
-  // the pre-existing warnings are cleaned up. https://crbug.com/467287
-  return DiagnosticsEngine::Warning;
-#else
-  return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
-                                            : DiagnosticsEngine::Warning;
-#endif
-}
-
 // Returns true if |base| specifies one of the Chromium reference counted
 // classes (base::RefCounted / base::RefCountedThreadSafe).
 bool FindBadConstructsConsumer::IsRefCountedCallback(
     const CXXBaseSpecifier* base,
     CXXBasePath& path,
     void* user_data) {
   FindBadConstructsConsumer* self =
       static_cast<FindBadConstructsConsumer*>(user_data);
 
   const TemplateSpecializationType* base_type =
@@ skipping 211 matching lines @@
     // one of those, it means there is at least one member after a factory.
     if (weak_ptr_factory_location.isValid() &&
         !param_is_weak_ptr_factory_to_self) {
       diagnostic().Report(weak_ptr_factory_location,
                           diag_weak_ptr_factory_order_);
     }
   }
 }
 
 }  // namespace chrome_checker