Clang style plugin: add warn-only option and use it on Windows

tools/clang/plugins/FindBadConstructsAction.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "FindBadConstructsAction.h"
 
 #include "clang/AST/ASTConsumer.h"
 #include "clang/Frontend/FrontendPluginRegistry.h"
 
 #include "FindBadConstructsConsumer.h"
@@ skipping 39 matching lines @@
       // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
       options_.check_base_classes = true;
     } else if (args[i] == "check-enum-last-value") {
       // TODO(tsepez): Enable this by default once http://crbug.com/356815
       // and http://crbug.com/356816 are fixed.
       options_.check_enum_last_value = true;
     } else if (args[i] == "with-ast-visitor") {
       options_.with_ast_visitor = true;
     } else if (args[i] == "check-templates") {
       options_.check_templates = true;
+    } else if (args[i] == "warn-only") {
+      options_.warn_only = true;

[Nico, 2015/04/30 23:08:04]

I'd make this block windows-only

[hans, 2015/04/30 23:13:32]

that's ok)

I like that test. It found the bug when I hadn't updated both functions where we
computed the error level.

I want to keep the test so I'd rather not make the flag windows-only.

     } else {
       parsed = false;
       llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
     }
   }
 
   return parsed;
 }
 
 }  // namespace chrome_checker
 
 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
     "find-bad-constructs",
     "Finds bad C++ constructs");