Clang style plugin: add warn-only option and use it on Windows

build/config/clang/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("clang.gni")
 
 config("find_bad_constructs") {
   if (clang_use_chrome_plugins) {
     cflags = []
 
@@ skipping 13 matching lines @@
       cflags += [
         "-Xclang",
         "-load",
         "-Xclang",
         rebase_path(
             "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",
             root_build_dir),
       ]
     }
 
+    if (is_win) {
+      # Don't error on plugin warnings on Windows until pre-existing warnings
+      # are cleaned up.  https://crbug.com/467287
+      cflags += [
+        "-Xclang",
+        "-plugin-arg-find-bad-constructs",
+        "-Xclang warn-only",
+      ]
+    }
+
     cflags += [
       "-Xclang",
       "-add-plugin",
       "-Xclang",
       "find-bad-constructs",
     ]
   }
 }
 
 # Enables some extra Clang-specific warnings. Some third-party code won't
 # compile with these so may want to remove this config.
 config("extra_warnings") {
   cflags = [
     "-Wheader-hygiene",
 
     # Warns when a const char[] is converted to bool.
     "-Wstring-conversion",
   ]
 }