Issue 111713002: Sk_API for SkImageGenerator and SkInstallDiscardablePixelRef

Issue 111713002: Sk_API for SkImageGenerator and SkInstallDiscardablePixelRef (Closed)

Created:
7 years ago by hal.canary

Modified:
7 years ago

Reviewers:
hclam, mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Sk_API for SkImageGenerator and SkInstallDiscardablePixelRef Added SK_API to SkImageGenerator (already in include/). Moved SkDiscardablePixelRef::Install to SkInstallDiscardablePixelRef, added SK_API to that function, and moved declaration to SkImageGenerator.h This keeps the SkDiscardablePixelRef internal to Skia, but exposes a method to install it into a bitmap. Modifed tests that rely on this functio to use new version. BUG= R=mtklein@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12612

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix whitespace #

Patch Set 3 : move friend decl #

Total comments: 2

Patch Set 4 : change from reed #

Patch Set 5 : one more chenage #

Patch Set 6 : rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -47 lines)			Patch
M	include/core/SkImageGenerator.h	View	1	1 chunk	+29 lines, -1 line	0 comments	Download
M	src/images/SkDecodingImageGenerator.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.h	View	1 2	2 chunks	+5 lines, -32 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1 2 3 4	2 chunks	+10 lines, -5 lines	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View	1 2 3 4 5	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/LazyDecodeBitmap.cpp	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mtklein

Just a nit; otherwise lgtm. https://codereview.chromium.org/111713002/diff/1/src/lazy/SkDiscardablePixelRef.cpp File src/lazy/SkDiscardablePixelRef.cpp (right): https://codereview.chromium.org/111713002/diff/1/src/lazy/SkDiscardablePixelRef.cpp#newcode67 src/lazy/SkDiscardablePixelRef.cpp:67: SkBitmap* dst, Tabs -> ...

7 years ago (2013-12-10 15:21:39 UTC) #2

hal.canary

https://codereview.chromium.org/111713002/diff/1/src/lazy/SkDiscardablePixelRef.cpp File src/lazy/SkDiscardablePixelRef.cpp (right): https://codereview.chromium.org/111713002/diff/1/src/lazy/SkDiscardablePixelRef.cpp#newcode67 src/lazy/SkDiscardablePixelRef.cpp:67: SkBitmap* dst, On 2013/12/10 15:21:39, mtklein wrote: > Tabs ...

7 years ago (2013-12-10 15:45:29 UTC) #3

reed1

lgtm https://codereview.chromium.org/111713002/diff/40001/src/lazy/SkDiscardablePixelRef.cpp File src/lazy/SkDiscardablePixelRef.cpp (right): https://codereview.chromium.org/111713002/diff/40001/src/lazy/SkDiscardablePixelRef.cpp#newcode74 src/lazy/SkDiscardablePixelRef.cpp:74: || (0 == dst->getSize())) { // dst->getSize=0 Probably ...

7 years ago (2013-12-10 16:42:42 UTC) #4

hal.canary

https://codereview.chromium.org/111713002/diff/40001/src/lazy/SkDiscardablePixelRef.cpp File src/lazy/SkDiscardablePixelRef.cpp (right): https://codereview.chromium.org/111713002/diff/40001/src/lazy/SkDiscardablePixelRef.cpp#newcode74 src/lazy/SkDiscardablePixelRef.cpp:74: || (0 == dst->getSize())) { // dst->getSize=0 Probably a ...

7 years ago (2013-12-10 16:57:53 UTC) #5

hal.canary

Committed patchset #6 manually as r12612 (presubmit successful).

7 years ago (2013-12-10 21:11:21 UTC) #6

Alpha Left Google

7 years ago (2013-12-10 21:26:10 UTC) #7

Message was sent while issue was closed.

On 2013/12/10 21:11:21, Hal Canary wrote:
> Committed patchset #6 manually as r12612 (presubmit successful).

Please let met know if this is rolled to chrome.

Expand Messages | Collapse Messages