Issue 1117123003: Revert of Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1117123003: Revert of Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk(). (Closed)

Created:
5 years, 7 months ago by Lei Zhang

Modified:
5 years, 7 months ago

Reviewers:
Derek Bruening, earthdok

CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk(). (patchset #1 id:1 of https://codereview.chromium.org/1110243003/) Reason for revert: Turned all the DrMemory bots red. Original issue's description: > Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk(). > > BUG=481231 > TBR=earthdok@chromium.org > NOTRY=true > > Committed: https://crrev.com/646b3185e4958a3ab0676717fe048fd6bf6ebb17 > Cr-Commit-Position: refs/heads/master@{#327364} TBR=earthdok@chromium.org,bruening@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481231 Committed: https://crrev.com/93dc94c20e0ddf34dff582db05d72a9b06ea0bf0 Cr-Commit-Position: refs/heads/master@{#327980}

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -2 lines)			Patch
M	third_party/drmemory/README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/drmemory/drmemory-windows-sfx.exe.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/gtest_exclude/base_unittests.gtest-drmemory_win32.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

Created Revert of Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk().

5 years, 7 months ago (2015-05-01 21:00:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117123003/1

5 years, 7 months ago (2015-05-01 21:01:54 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-01 21:07:27 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/93dc94c20e0ddf34dff582db05d72a9b06ea0bf0
Cr-Commit-Position: refs/heads/master@{#327980}