Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1117123002: Fix distiller feedback regression (Closed)

Created:
5 years, 7 months ago by mdjones
Modified:
5 years, 4 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix distiller feedback regression Feedback form for distiller should always be at the bottom of the page. Regression caused by: https://codereview.chromium.org/1009703002/ BUG= Committed: https://crrev.com/4d00b3ccc37ce2032c6973ea304d1ff65b3e673a Cr-Commit-Position: refs/heads/master@{#327810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/dom_distiller/core/css/distilledpage.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mdjones
5 years, 7 months ago (2015-04-30 20:28:04 UTC) #2
nyquist
lgtm
5 years, 7 months ago (2015-04-30 20:39:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117123002/1
5 years, 7 months ago (2015-04-30 20:40:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 22:33:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4d00b3ccc37ce2032c6973ea304d1ff65b3e673a Cr-Commit-Position: refs/heads/master@{#327810}
5 years, 7 months ago (2015-04-30 22:35:32 UTC) #7
csaavedra
On 2015/04/30 22:35:32, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 4 months ago (2015-08-12 13:10:29 UTC) #8
wychen
5 years, 4 months ago (2015-08-16 00:37:36 UTC) #9
Message was sent while issue was closed.
On 2015/08/12 13:10:29, csaavedra wrote:
> On 2015/04/30 22:35:32, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/4d00b3ccc37ce2032c6973ea304d1ff65b3e673a
> > Cr-Commit-Position: refs/heads/master@{#327810}
> 
> Actually this is breaking printing a distilled page. There's an empty page at
> the beginning of any distilled document when printing it. Reverting this patch
> fixes that. Also (at least in Linux builds), I cannot reproduce this bug at
all,
> so the patch might be unneeded at this point.
> 
> (Why this is adding an empty page at the beginning of the printout is still a
> mystery to me. There might be a layout issue somewhere)

Thanks for reporting this.
Tracked here: http://crbug.com/521333

Powered by Google App Engine
This is Rietveld 408576698