Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: chrome/version.gni

Issue 1117063004: Revert of Add a GN flag for the Windows multi-dll build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome_elf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/version.gni
diff --git a/chrome/version.gni b/chrome/version.gni
index 1d424a6de0887b41dfc51e150cfe679daf634e62..b956e9c38e5084fae3b4569c86d3ba88d36412fb 100644
--- a/chrome/version.gni
+++ b/chrome/version.gni
@@ -2,14 +2,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//build/config/chrome_build.gni")
-
# Runs the version processing script over the given template file to produce
# an output file. This is used for generating various forms of files that
# incorporate the product name and version.
-#
-# Unlike GYP, this will actually compile the resulting file, so you don't need
-# to add it separately to the sources, just depend on the target.
#
# This template automatically includes VERSION, LASTCHANGE, and BRANDING. It
# automatically uses the template file .
@@ -55,11 +50,10 @@
"Either sources or template_file must be defined for $target_name")
assert(defined(invoker.output), "Output must be defined for $target_name")
- action_name = target_name + "_action"
- source_set_name = target_name
-
- action(action_name) {
- visibility = [ ":$source_set_name" ]
+ action(target_name) {
+ if (defined(invoker.visibility)) {
+ visibility = invoker.visibility
+ }
script = "//build/util/version.py"
lastchange_path = "//build/util/LASTCHANGE"
@@ -114,14 +108,4 @@
rebase_path(invoker.output, root_build_dir),
]
}
-
- source_set(source_set_name) {
- if (defined(invoker.visibility)) {
- visibility = invoker.visibility
- }
- sources = get_target_outputs(":$action_name")
- deps = [
- ":$action_name",
- ]
- }
}
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome_elf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698