Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1117063004: Revert of Add a GN flag for the Windows multi-dll build. (Closed)

Created:
5 years, 7 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 7 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, sadrul, kalyank, chromoting-reviews_chromium.org, grt+watch_chromium.org, jam, eme-reviews_chromium.org, darin-cc_chromium.org, wfh+watch_chromium.org, piman+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a GN flag for the Windows multi-dll build. (patchset #3 id:40001 of https://codereview.chromium.org/1120803003/) Reason for revert: May have caused some link errors on windows: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/814 Original issue's description: > Add a GN flag for the Windows multi-dll build. > > The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. > > R=scottmg@chromium.org > TBR=ddorwin@chromium.org (widevine) > > Committed: https://crrev.com/edff53a35780ba2f515c7e8d4f7131c91151e1a3 > Cr-Commit-Position: refs/heads/master@{#327854} TBR=scottmg@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e203954b33d80072a7c8d256ffdc69fa42262765 Cr-Commit-Position: refs/heads/master@{#327861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -136 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D build/config/chrome_build.gni View 1 chunk +0 lines, -21 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 6 chunks +6 lines, -54 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/policy.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/version.gni View 3 chunks +4 lines, -20 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M content/app/BUILD.gn View 5 chunks +6 lines, -5 lines 0 comments Download
M content/public/app/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_version.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/webapp/build_template.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/adobe/flash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rickyz (no longer on Chrome)
Created Revert of Add a GN flag for the Windows multi-dll build.
5 years, 7 months ago (2015-05-01 01:43:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117063004/1
5 years, 7 months ago (2015-05-01 01:43:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 01:45:11 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 01:46:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e203954b33d80072a7c8d256ffdc69fa42262765
Cr-Commit-Position: refs/heads/master@{#327861}

Powered by Google App Engine
This is Rietveld 408576698