Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Issue 1117033005: Clean up removeContentScripts in web_view_internal.json. (Closed)

Created:
5 years, 7 months ago by Xi Han
Modified:
5 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up removeContentScripts in web_view_internal.json. Remove the uncessary callback in the API definition. BUG=461052 Committed: https://crrev.com/28047eae7f427ae72f69871eeb5d9a0f2239401c Cr-Commit-Position: refs/heads/master@{#327782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M extensions/common/api/web_view_internal.json View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xi Han
Forget to clean up the removeContentScripts in my previous patch, updated here.
5 years, 7 months ago (2015-04-30 19:17:38 UTC) #1
Xi Han
Forget to clean up the removeContentScripts in my previous patch, updated here.
5 years, 7 months ago (2015-04-30 19:17:58 UTC) #3
Fady Samuel
Thanks! lgtm!
5 years, 7 months ago (2015-04-30 19:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117033005/1
5 years, 7 months ago (2015-04-30 19:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 20:35:06 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 20:36:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28047eae7f427ae72f69871eeb5d9a0f2239401c
Cr-Commit-Position: refs/heads/master@{#327782}

Powered by Google App Engine
This is Rietveld 408576698