Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: extensions/browser/extension_web_contents_observer.h

Issue 1117023002: Keep event page alive when there's some Pepper plugin on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK instead of null-pointer condition check. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_web_contents_observer.h
diff --git a/extensions/browser/extension_web_contents_observer.h b/extensions/browser/extension_web_contents_observer.h
index 993a8fe4cec02e6070e99b181891b02b85296d58..d36d782555131e8c5ae296654f6063a3b5d8a342 100644
--- a/extensions/browser/extension_web_contents_observer.h
+++ b/extensions/browser/extension_web_contents_observer.h
@@ -49,6 +49,11 @@ class ExtensionWebContentsObserver : public content::WebContentsObserver {
void RenderFrameHostChanged(content::RenderFrameHost* old_host,
content::RenderFrameHost* new_host) override;
+ // Per the documentation in WebContentsObserver, these two methods are invoked
+ // when a Pepper plugin instance is attached/detached in the page DOM.
+ void PepperInstanceCreated() override;
+ void PepperInstanceDeleted() override;
+
// Returns the extension or app associated with a render view host. Returns
// NULL if the render view host is not for a valid extension.
const Extension* GetExtension(content::RenderViewHost* render_view_host);

Powered by Google App Engine
This is Rietveld 408576698