Keep event page alive when there's some Pepper plugin on it.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 1161 matching lines @@
 }
 
 blink::WebView* RenderViewImpl::webview() const {
   return static_cast<blink::WebView*>(webwidget());
 }
 
 #if defined(ENABLE_PLUGINS)
 void RenderViewImpl::PepperInstanceCreated(
     PepperPluginInstanceImpl* instance) {
   active_pepper_instances_.insert(instance);
+
+  RenderFrameImpl* const render_frame = instance->render_frame();
+  if (render_frame)

[nasko, 2015/05/19 17:49:34]

RenderFrame should never be null, so there is no reason to check the pointer for
validity. A crash on the call to Send would indicate a bug and we will want to
know about it.

[emaxx, 2015/05/19 18:14:59]

You are right.
I've now placed a DCHECK here - to reassure and to show the intention.

[nasko, 2015/05/19 18:51:51]

In general, we don't add DCHECK when the line after is going to crash anyway.
The nullptr crash is equivalent to the DCHECK, so let's remove those.

+    render_frame->Send(
+        new FrameHostMsg_PepperInstanceCreated(render_frame->GetRoutingID()));
 }
 
 void RenderViewImpl::PepperInstanceDeleted(
     PepperPluginInstanceImpl* instance) {
   active_pepper_instances_.erase(instance);
 
   if (pepper_last_mouse_event_target_ == instance)
     pepper_last_mouse_event_target_ = NULL;
   if (focused_pepper_plugin_ == instance)
     PepperFocusChanged(instance, false);
+
+  RenderFrameImpl* const render_frame = instance->render_frame();
+  if (render_frame)
+    render_frame->Send(
+        new FrameHostMsg_PepperInstanceDeleted(render_frame->GetRoutingID()));
 }
 
 void RenderViewImpl::PepperFocusChanged(PepperPluginInstanceImpl* instance,
                                         bool focused) {
   if (focused)
     focused_pepper_plugin_ = instance;
   else if (focused_pepper_plugin_ == instance)
     focused_pepper_plugin_ = NULL;
 
   UpdateTextInputType();
@@ skipping 2567 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content