Keep event page alive when there's some Pepper plugin on it.

chrome/browser/extensions/lazy_background_page_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/command_line.h"
 #include "base/files/file_path.h"
+#include "base/path_service.h"
 #include "base/scoped_observer.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/lazy_background_page_test_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/location_bar/location_bar.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/app_modal/app_modal_dialog.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/browser/bookmark_utils.h"
 #include "components/bookmarks/test/bookmark_test_helpers.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
+#include "content/public/test/test_utils.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_registry_observer.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/extension.h"
 #include "extensions/test/extension_test_message_listener.h"
 #include "extensions/test/result_catcher.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "url/gurl.h"
@@ skipping 50 matching lines @@
   LazyBackgroundPageApiTest() {}
   ~LazyBackgroundPageApiTest() override {}
 
   void SetUpOnMainThread() override {
     ExtensionApiTest::SetUpOnMainThread();
     // Set shorter delays to prevent test timeouts.
     extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);
     extensions::ProcessManager::SetEventPageSuspendingTimeForTesting(1);
   }
 
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    ExtensionApiTest::SetUpCommandLine(command_line);
+    // Disable background network activity as it can suddenly bring the Lazy
+    // Background Page alive.
+    command_line->AppendSwitch(switches::kDisableBackgroundNetworking);
+    command_line->AppendSwitch(switches::kNoProxyServer);
+  }
+
   // Loads the extension, which temporarily starts the lazy background page
   // to dispatch the onInstalled event. We wait until it shuts down again.
   const Extension* LoadExtensionAndWait(const std::string& test_name) {
     LazyBackgroundObserver page_complete;
     base::FilePath extdir = test_data_dir_.AppendASCII("lazy_background_page").
         AppendASCII(test_name);
     const Extension* extension = LoadExtension(extdir);
     if (extension)
       page_complete.Wait();
     return extension;
@@ skipping 186 matching lines @@
   bool result = false;
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       host->render_view_host(), "abortRequest()", &result));
   EXPECT_TRUE(result);
   page_complete.Wait();
 
   // Lazy Background Page has been shut down.
   EXPECT_FALSE(pm->GetBackgroundHostForExtension(last_loaded_extension_id()));
 }
 
+// Tests that the lazy background page stays alive while a NaCl module exists in
+// its DOM.
+IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, NaCl) {
+#if !defined(DISABLE_NACL)

[not at google - send to devlin, 2015/05/11 17:53:48]

Is it better to ifdef out the entire test? That way you won't get misleading
tests passing if the bots don't run nacl. May as well just not run the test.

[emaxx, 2015/05/18 15:06:29]

Done.

+  {
+    base::FilePath extdir;
+    ASSERT_TRUE(PathService::Get(chrome::DIR_GEN_TEST_DATA, &extdir));

[bartfab (slow), 2015/05/18 09:57:41]

Nit: #include "testing/gtest/include/gtest/gtest.h"

[emaxx, 2015/05/18 15:06:29]

Done.

+    extdir = extdir.AppendASCII("ppapi/tests/extensions/load_unload/newlib");
+    LazyBackgroundObserver page_complete;
+    ASSERT_TRUE(LoadExtension(base::FilePath(extdir)));

[bartfab (slow), 2015/05/18 09:57:41]

Why do you cast |extdir| to |base::FilePath| once more? It already has that
type.

[emaxx, 2015/05/18 15:06:29]

Done (it was left from some old version).

+    page_complete.Wait();
+  }
+
+  // The NaCl module is loaded, and the Lazy Background Page stays alive.
+  {
+    ExtensionTestMessageListener nacl_module_loaded("nacl_module_loaded",
+                                                    false);
+    BrowserActionTestUtil(browser()).Press(0);
+    nacl_module_loaded.WaitUntilSatisfied();
+    content::RunAllBlockingPoolTasksUntilIdle();

[not at google - send to devlin, 2015/05/11 17:53:48]

It's a pity, we're basically forcing this test to run > 10 seconds because
that's the timeout for event pages. Also, is RunAllBlockingPoolTasksUntilIdle
reliably going to wait for that, and/or not end up waiting for other things?
Surely other timers must go off.

For the former problem, perhaps at a scoped-override style of override for
g_event_page_idle_time_msec:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...

I wonder if setting it to 0 would work... and for that matter, I wonder if
setting to anything > 0 would be flaky? (we'd probably want to make that work
anyway).

for the latter... I'm not sure what the most appropriate way to do this. Wait an
extra second? Ehk. There must be a better way.

[bartfab (slow), 2015/05/18 09:57:41]

I would be worried not just about early returns but also about the opposite -
what if something else posts an unrelated task to the blocking pool, keeping it
busy for a long time, causing this test to time out and flake?

+1 to overriding the idle time or alternatively, manually triggering an idle
event from here.

[emaxx, 2015/05/18 15:06:29]

Actually the test class LazyBackgroundPageApiTest is already changing the delay
time from the default 10 seconds to 1 millisecond. But it was doing this inside
SetUpOnMainThread(), which turns out to be too late. Now I've fixed it (using
SetUpInProcessBrowserTestFixture() instead).

Now this test works about 1.5 - 2 seconds, the same as any other test in that
file (and most of the other tests have the similar structure, BTW).

[emaxx, 2015/05/18 15:06:29]

Done (see the answer above).

+    EXPECT_TRUE(IsBackgroundPageAlive(last_loaded_extension_id()));
+  }
+
+  // The NaCl module is detached from DOM, and the Lazy Background Page shuts
+  // down.
+  {
+    LazyBackgroundObserver page_complete;
+    BrowserActionTestUtil(browser()).Press(0);
+    page_complete.WaitUntilClosed();
+  }
+
+  // The Lazy Background Page has been shut down.
+  EXPECT_FALSE(IsBackgroundPageAlive(last_loaded_extension_id()));
+#endif
+}
+
 // Tests that the lazy background page stays alive until all visible views are
 // closed.
 // http://crbug.com/175778; test fails frequently on OS X
 #if defined(OS_MACOSX)
 #define MAYBE_WaitForNTP DISABLED_WaitForNTP
 #else
 #define MAYBE_WaitForNTP WaitForNTP
 #endif
 IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, MAYBE_WaitForNTP) {
   LazyBackgroundObserver lazybg;
@@ skipping 262 matching lines @@
 
 // Tests that the lazy background page will be unloaded if the onSuspend event
 // handler calls an API function such as chrome.storage.local.set().
 // See: http://crbug.com/296834
 IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, OnSuspendUseStorageApi) {
   EXPECT_TRUE(LoadExtensionAndWait("on_suspend"));
 }
 
 // TODO: background page with timer.
 // TODO: background page that interacts with popup.