Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1117013006: Pull string_util for posix too (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull string_util for posix too, to match available interface. Should have been included in 1554c70b0 / https://codereview.chromium.org/1119173003/. Drop the string16 one too. R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/bf64e609259be3faf24e32aa899491f22fa1fb90

Patch Set 1 #

Patch Set 2 : include #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M base/strings/string_util_posix.h View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M base/strings/string_util_win.h View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 7 months ago (2015-05-05 16:35:31 UTC) #1
Mark Mentovai
LGTM
5 years, 7 months ago (2015-05-05 16:38:49 UTC) #2
scottmg
5 years, 7 months ago (2015-05-05 17:00:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
bf64e609259be3faf24e32aa899491f22fa1fb90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698