Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1116953002: Migrate error messages, part 6. (string.js and date.js) (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 6. (string.js and date.js) R=mvstanton@chromium.org Committed: https://crrev.com/ac50edfee0c33ec74aeda261d3c1fcc05cd72dfe Cr-Commit-Position: refs/heads/master@{#28180}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -24 lines) Patch
M src/date.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/messages.js View 1 2 chunks +0 lines, -5 lines 0 comments Download
M src/string.js View 5 chunks +5 lines, -10 lines 0 comments Download
M test/mjsunit/messages.js View 4 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 7 months ago (2015-04-30 14:01:15 UTC) #1
mvstanton
lgtm
5 years, 7 months ago (2015-04-30 15:32:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116953002/20001
5 years, 7 months ago (2015-04-30 15:35:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 16:22:05 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 16:22:27 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac50edfee0c33ec74aeda261d3c1fcc05cd72dfe
Cr-Commit-Position: refs/heads/master@{#28180}

Powered by Google App Engine
This is Rietveld 408576698