Function apply(): make all architectures use an IC for performance.

src/mips/builtins-mips.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_MIPS
 
@@ skipping 1386 matching lines @@
   ParameterCount expected(0);
   __ InvokeCode(a3, expected, expected, JUMP_FUNCTION, NullCallWrapper());
 }
 
 
 static void Generate_PushAppliedArguments(MacroAssembler* masm,
                                           const int argumentsOffset,
                                           const int indexOffset,
                                           const int limitOffset) {
   Label entry, loop;
-  __ lw(a0, MemOperand(fp, indexOffset));
+  Register receiver = LoadDescriptor::ReceiverRegister();
+  Register key = LoadDescriptor::NameRegister();
+
+  __ lw(key, MemOperand(fp, indexOffset));
   __ Branch(&entry);
 
-  // Load the current argument from the arguments array and push it to the
-  // stack.
-  // a0: current argument index
+  // Load the current argument from the arguments array.
   __ bind(&loop);
-  __ lw(a1, MemOperand(fp, argumentsOffset));
-  __ Push(a1, a0);
+  __ lw(receiver, MemOperand(fp, argumentsOffset));
 
-  // Call the runtime to access the property in the arguments array.
-  __ CallRuntime(Runtime::kGetProperty, 2);
+  // Use inline caching to speed up access to arguments.
+  Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Megamorphic();
+  __ Call(ic, RelocInfo::CODE_TARGET);
+
   __ push(v0);
 
   // Use inline caching to access the arguments.
-  __ lw(a0, MemOperand(fp, indexOffset));
-  __ Addu(a0, a0, Operand(1 << kSmiTagSize));
-  __ sw(a0, MemOperand(fp, indexOffset));
+  __ lw(key, MemOperand(fp, indexOffset));
+  __ Addu(key, key, Operand(1 << kSmiTagSize));
+  __ sw(key, MemOperand(fp, indexOffset));
 
   // Test if the copy loop has finished copying all the elements from the
   // arguments object.
   __ bind(&entry);
   __ lw(a1, MemOperand(fp, limitOffset));
-  __ Branch(&loop, ne, a0, Operand(a1));
+  __ Branch(&loop, ne, key, Operand(a1));
 
   // On exit, the pushed arguments count is in a0, untagged
+  __ mov(a0, key);
   __ SmiUntag(a0);
 }
 
 
 // Used by FunctionApply and ReflectApply
 static void Generate_ApplyHelper(MacroAssembler* masm, bool targetIsArgument) {
   const int kFormalParameters = targetIsArgument ? 3 : 2;
   const int kStackSize = kFormalParameters + 1;
 
   {
@@ skipping 369 matching lines @@
     __ break_(0xCC);
   }
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_MIPS