Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1116923003: simple cleanup in GrTargetCommands (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simple cleanup in GrTargetCommands BUG=skia: Committed: https://skia.googlesource.com/skia/+/a30009bec5d495b4524b746142a2afa4452908de

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -65 lines) Patch
M src/gpu/GrTargetCommands.h View 4 chunks +9 lines, -34 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 8 chunks +6 lines, -28 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 7 months ago (2015-04-30 14:31:45 UTC) #2
robertphillips
lgtm + questions https://codereview.chromium.org/1116923003/diff/1/src/gpu/GrTargetCommands.cpp File src/gpu/GrTargetCommands.cpp (right): https://codereview.chromium.org/1116923003/diff/1/src/gpu/GrTargetCommands.cpp#newcode37 src/gpu/GrTargetCommands.cpp:37: // Check if there is a ...
5 years, 7 months ago (2015-04-30 15:51:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116923003/20001
5 years, 7 months ago (2015-04-30 16:01:20 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 16:06:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a30009bec5d495b4524b746142a2afa4452908de

Powered by Google App Engine
This is Rietveld 408576698