Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: Source/core/css/CSSStyleDeclaration.cpp

Issue 1116903002: [bindings] Remove custom namedPropertyEnumerator from CSSStyleDeclaration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSStyleDeclaration.h ('k') | Source/core/css/CSSStyleDeclaration.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSStyleDeclaration.cpp
diff --git a/Source/core/css/CSSStyleDeclaration.cpp b/Source/core/css/CSSStyleDeclaration.cpp
index 712f2ddb0b4cfd7ca62dce3d5a76b7c2abed6402..9f11edad0c45abcea4acde5f40a6f9be390084fa 100644
--- a/Source/core/css/CSSStyleDeclaration.cpp
+++ b/Source/core/css/CSSStyleDeclaration.cpp
@@ -125,4 +125,25 @@ bool CSSStyleDeclaration::anonymousNamedSetter(ScriptState* scriptState, const S
return true;
}
+void CSSStyleDeclaration::namedPropertyEnumerator(Vector<String>& names, ExceptionState&)
+{
+ typedef Vector<String, numCSSProperties - 1> PreAllocatedPropertyVector;
+ DEFINE_STATIC_LOCAL(PreAllocatedPropertyVector, propertyNames, ());
+ static unsigned propertyNamesLength = 0;
+ if (propertyNames.isEmpty()) {
+ for (int id = firstCSSProperty; id <= lastCSSProperty; ++id) {
+ CSSPropertyID propertyId = static_cast<CSSPropertyID>(id);
+ if (CSSPropertyMetadata::isEnabledProperty(propertyId))
+ propertyNames.append(getJSPropertyName(propertyId));
+ }
+ std::sort(propertyNames.begin(), propertyNames.end(), codePointCompareLessThan);
+ propertyNamesLength = propertyNames.size();
+ }
+ for (unsigned i = 0; i < propertyNamesLength; ++i) {
+ String key = propertyNames.at(i);
+ ASSERT(!key.isNull());
+ names.append(key);
+ }
+}
+
}
« no previous file with comments | « Source/core/css/CSSStyleDeclaration.h ('k') | Source/core/css/CSSStyleDeclaration.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698