Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 1116903002: [bindings] Remove custom namedPropertyEnumerator from CSSStyleDeclaration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSStyleDeclaration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
index e26086af3fe9e0b6f64af61848bb04b8038fea53..2625d258589fb29b72ebdfb8a44bc04911378fd4 100644
--- a/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
@@ -151,32 +151,6 @@ static CSSPropertyID cssPropertyInfo(v8::Local<v8::String> v8PropertyName, v8::I
return unresolvedProperty;
}
-void V8CSSStyleDeclaration::namedPropertyEnumeratorCustom(const v8::PropertyCallbackInfo<v8::Array>& info)
-{
- typedef Vector<String, numCSSProperties - 1> PreAllocatedPropertyVector;
- DEFINE_STATIC_LOCAL(PreAllocatedPropertyVector, propertyNames, ());
- static unsigned propertyNamesLength = 0;
-
- if (propertyNames.isEmpty()) {
- for (int id = firstCSSProperty; id <= lastCSSProperty; ++id) {
- CSSPropertyID propertyId = static_cast<CSSPropertyID>(id);
- if (CSSPropertyMetadata::isEnabledProperty(propertyId))
- propertyNames.append(getJSPropertyName(propertyId));
- }
- std::sort(propertyNames.begin(), propertyNames.end(), codePointCompareLessThan);
- propertyNamesLength = propertyNames.size();
- }
-
- v8::Local<v8::Array> properties = v8::Array::New(info.GetIsolate(), propertyNamesLength);
- for (unsigned i = 0; i < propertyNamesLength; ++i) {
- String key = propertyNames.at(i);
- ASSERT(!key.isNull());
- properties->Set(v8::Integer::New(info.GetIsolate(), i), v8String(info.GetIsolate(), key));
- }
-
- v8SetReturnValue(info, properties);
-}
-
void V8CSSStyleDeclaration::namedPropertyQueryCustom(v8::Local<v8::Name> v8Name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
if (!v8Name->IsString())
« no previous file with comments | « no previous file | Source/core/css/CSSStyleDeclaration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698