Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1116853002: [base] Drop obsolete Thread::YieldCPU. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[base] Drop obsolete Thread::YieldCPU. The method is not used anywhere, and it is a bad idea in general anyway. If you see a need to call YieldCPU, then you're code is probably in need of a redesign! R=svenpanne@chromium.org Committed: https://crrev.com/cf420ec337e47bed2c754d4ebdc87e8d1bb3cfe5 Cr-Commit-Position: refs/heads/master@{#28147}

Patch Set 1 #

Patch Set 2 : Of course also remove it from the cctest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -23 lines) Patch
M src/base/platform/platform.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/base/platform/platform-posix.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M test/cctest/test-threads.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-04-30 04:59:44 UTC) #1
Benedikt Meurer
Hey Sven, This should be self explanatory. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-04-30 05:00:22 UTC) #2
Sven Panne
lgtm
5 years, 7 months ago (2015-04-30 08:06:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116853002/20001
5 years, 7 months ago (2015-04-30 08:07:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 08:08:52 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 08:09:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf420ec337e47bed2c754d4ebdc87e8d1bb3cfe5
Cr-Commit-Position: refs/heads/master@{#28147}

Powered by Google App Engine
This is Rietveld 408576698