Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp

Issue 1116843002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Mac compilation error for v8::Isolate* should be the first parameter patch Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp
diff --git a/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp b/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp
index 0e5df86a76af7df1b8b5104a37a0f713552bbfe3..e3282e51c9b0536aa1ee507cad80d57f6eb2962f 100644
--- a/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp
+++ b/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp
@@ -12,7 +12,7 @@
namespace blink {
-PassRefPtr<SerializedScriptValue> SerializedScriptValueForModulesFactory::create(v8::Local<v8::Value> value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, WebBlobInfoArray* blobInfo, ExceptionState& exceptionState, v8::Isolate* isolate)
+PassRefPtr<SerializedScriptValue> SerializedScriptValueForModulesFactory::create(v8::Isolate* isolate, v8::Local<v8::Value> value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, WebBlobInfoArray* blobInfo, ExceptionState& exceptionState)
{
RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::create();
SerializedScriptValueWriterForModules writer;
@@ -43,7 +43,7 @@ PassRefPtr<SerializedScriptValue> SerializedScriptValueForModulesFactory::create
return serializedValue.release();
}
-PassRefPtr<SerializedScriptValue> SerializedScriptValueForModulesFactory::create(const String& data, v8::Isolate* isolate)
+PassRefPtr<SerializedScriptValue> SerializedScriptValueForModulesFactory::create(v8::Isolate* isolate, const String& data)
{
SerializedScriptValueWriterForModules writer;
writer.writeWebCoreString(data);
« no previous file with comments | « Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698