Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 1116773003: Remove unnecessary clearing of AX object cache in Document destructor. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
haraken, dmazzoni
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unnecessary clearing of AX object cache in Document destructor. Only frame-attached Documents can have an AX object cache. All such Documents will be explicitly detached; detach() will clear the AX object cache. Thus clearing it again in the destructor ought to be redundant -- leave in an assert to verify that this assumption will hold. R=dmazzoni,haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
please take a look. (following up on https://codereview.chromium.org/1089813004/#msg19 )
5 years, 7 months ago (2015-04-30 06:24:53 UTC) #2
dmazzoni
lgtm Makes sense! We'll learn soon enough if there's some obscure corner case where this ...
5 years, 7 months ago (2015-04-30 06:38:00 UTC) #3
haraken
LGTM
5 years, 7 months ago (2015-04-30 07:07:39 UTC) #4
sof
Linux dbg bots aren't picking up anything new, so let's try.
5 years, 7 months ago (2015-04-30 10:52:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116773003/1
5 years, 7 months ago (2015-04-30 10:52:46 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 11:47:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194732

Powered by Google App Engine
This is Rietveld 408576698