Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1116763002: Gracefully handle unruly children detaching our frame and client. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
Nate Chapin, dcheng
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Gracefully handle unruly children detaching our frame and client. When committing the load of a new document to a frame, any current document is first detached, along with the child frames. Should these children trigger the detachment of the frame getting a new document, by updating the frame tree above us, simply abandon the frame loading operation. R=japhet,dcheng BUG=476837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
A LayoutTests/fast/frames/detach-frame-nested-on-commit-no-crash.html View 1 chunk +31 lines, -0 lines 0 comments Download
A + LayoutTests/fast/frames/detach-frame-nested-on-commit-no-crash-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 7 months ago (2015-04-29 19:44:41 UTC) #2
Nate Chapin
lgtm
5 years, 7 months ago (2015-04-29 19:47:53 UTC) #3
dcheng
lgtm
5 years, 7 months ago (2015-04-29 20:00:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116763002/1
5 years, 7 months ago (2015-04-29 20:57:19 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 23:47:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194679

Powered by Google App Engine
This is Rietveld 408576698