Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: content/browser/notifications/page_notification_delegate.cc

Issue 1116693002: [NOT FOR REVIEW] Significantly simplify the PlatformNotificationService //content API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/page_notification_delegate.cc
diff --git a/content/browser/notifications/page_notification_delegate.cc b/content/browser/notifications/page_notification_delegate.cc
index fdf085d7c7ca6bc48b846ec9fb2b8427938d2417..cc6999bc5ae05bbd760eeeacb09725a7712bb71a 100644
--- a/content/browser/notifications/page_notification_delegate.cc
+++ b/content/browser/notifications/page_notification_delegate.cc
@@ -18,7 +18,7 @@ PageNotificationDelegate::PageNotificationDelegate(int render_process_id,
PageNotificationDelegate::~PageNotificationDelegate() {}
-void PageNotificationDelegate::NotificationDisplayed() {
+void PageNotificationDelegate::Display() {
RenderProcessHost* sender = RenderProcessHost::FromID(render_process_id_);
if (!sender)
return;
@@ -26,7 +26,7 @@ void PageNotificationDelegate::NotificationDisplayed() {
sender->Send(new PlatformNotificationMsg_DidShow(notification_id_));
}
-void PageNotificationDelegate::NotificationClosed() {
+void PageNotificationDelegate::Close(bool by_user) {
RenderProcessHost* sender = RenderProcessHost::FromID(render_process_id_);
if (!sender)
return;
@@ -36,7 +36,11 @@ void PageNotificationDelegate::NotificationClosed() {
->notification_message_filter()->DidCloseNotification(notification_id_);
}
-void PageNotificationDelegate::NotificationClick() {
+bool PageNotificationDelegate::HasClickedListener() {
+ return true;
+}
+
+void PageNotificationDelegate::Click() {
RenderProcessHost* sender = RenderProcessHost::FromID(render_process_id_);
if (!sender)
return;

Powered by Google App Engine
This is Rietveld 408576698