Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1116643005: Do not display CRAS loopback devices on UI. (Closed)

Created:
5 years, 7 months ago by chinyue
Modified:
5 years, 7 months ago
Reviewers:
dgreid, jennyz
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not display CRAS loopback devices on UI. Both POST_MIX and POST_DSP loopback devices are filtered out. BUG=479848 Committed: https://crrev.com/f76f3405ad9bae1ef3725046169f7cc4e34a6dbb Cr-Commit-Position: refs/heads/master@{#327863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/audio/audio_device.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/audio/audio_device.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dgreid
Thanks, that looks really good.
5 years, 7 months ago (2015-04-30 16:11:07 UTC) #2
jennyz
lgtm
5 years, 7 months ago (2015-04-30 17:15:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116643005/1
5 years, 7 months ago (2015-05-01 01:06:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 01:46:33 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 01:47:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f76f3405ad9bae1ef3725046169f7cc4e34a6dbb
Cr-Commit-Position: refs/heads/master@{#327863}

Powered by Google App Engine
This is Rietveld 408576698