Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1116633002: Pass ArrayBuffer::Allocator via Isolate::CreateParams (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass ArrayBuffer::Allocator via Isolate::CreateParams We shouldn't have shared state between isolates by default. The embedder is free to pass the same allocator to all isolates it creates. BUG=none R=dcarney@chromium.org LOG=y Committed: https://crrev.com/9ba5fe028f5420012cd161820ff0a6fa0e1e8a68 Cr-Commit-Position: refs/heads/master@{#28127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -170 lines) Patch
M include/v8.h View 7 chunks +18 lines, -7 lines 0 comments Download
M samples/process.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M samples/shell.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/api.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 6 chunks +42 lines, -32 lines 0 comments Download
M src/extensions/free-buffer-extension.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/isolate.h View 3 chunks +9 lines, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/snapshot/mksnapshot.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +10 lines, -0 lines 0 comments Download
M test/cctest/cctest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 15 chunks +37 lines, -13 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 9 chunks +27 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M test/cctest/test-lockers.cc View 11 chunks +33 lines, -12 lines 0 comments Download
M test/cctest/test-log.cc View 6 chunks +37 lines, -31 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-random-number-generator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 12 chunks +27 lines, -8 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-typedarrays.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/run-all-unittests.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M test/unittests/test-utils.h View 2 chunks +3 lines, -0 lines 0 comments Download
M test/unittests/test-utils.cc View 3 chunks +19 lines, -1 line 0 comments Download
M tools/parser-shell.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-04-29 09:30:24 UTC) #1
dcarney
lgtm
5 years, 7 months ago (2015-04-29 09:34:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116633002/1
5 years, 7 months ago (2015-04-29 09:37:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 09:54:39 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 09:54:54 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ba5fe028f5420012cd161820ff0a6fa0e1e8a68
Cr-Commit-Position: refs/heads/master@{#28127}

Powered by Google App Engine
This is Rietveld 408576698