media/audio/audio_output_device.cc - Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_output_device.cc

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Link to crbug from TODO comments. Enforced ownership transfer using scoped_ptr. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_platform_audio_output_impl.cc ('K') | « media/audio/audio_output_device.h ('k') | media/audio/audio_output_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/audio_output_device.cc

diff --git a/media/audio/audio_output_device.cc b/media/audio/audio_output_device.cc

index d09e32c4a77c6f2805a5bd95ee42023420339fc0..8872896058294571a0e1e1389975f110e0bcc58e 100644

--- a/media/audio/audio_output_device.cc

+++ b/media/audio/audio_output_device.cc

@@ -41,12 +41,12 @@ class AudioOutputDevice::AudioThreadCallback

};

AudioOutputDevice::AudioOutputDevice(

- AudioOutputIPC* ipc,

+ scoped_ptr<AudioOutputIPC> ipc,

const scoped_refptr<base::MessageLoopProxy>& io_loop)

: ScopedLoopObserver(io_loop),

input_channels_(0),

callback_(NULL),

- ipc_(ipc),

+ ipc_(ipc.Pass()),

stream_id_(0),

play_on_start_(true),

is_started_(false),

@@ -259,7 +259,7 @@ void AudioOutputDevice::OnStreamCreated(

}

void AudioOutputDevice::OnIPCClosed() {

- ipc_ = NULL;

+ ipc_.reset();

}

void AudioOutputDevice::WillDestroyCurrentMessageLoop() {