content/renderer/media/media_stream_dependency_factory.cc - Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: VLOG --> DVLOG in audio*renderer_host.cc Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_message_filter.h ('K') | « content/renderer/media/audio_renderer_mixer_manager_unittest.cc ('k') | content/renderer/media/render_audiosourceprovider.h » ('j') | media/audio/audio_output_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_dependency_factory.cc

diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc

index 15229d261d192b51c229a1711df4db0b100d0904..885df2e0e84bf79590aecc13dcc5a0e7a54c606f 100644

--- a/content/renderer/media/media_stream_dependency_factory.cc

+++ b/content/renderer/media/media_stream_dependency_factory.cc

@@ -198,7 +198,10 @@ bool MediaStreamDependencyFactory::CreateNativeLocalMediaStream(

bool MediaStreamDependencyFactory::CreatePeerConnectionFactory() {

if (!pc_factory_.get()) {

DCHECK(!audio_device_);

- audio_device_ = new WebRtcAudioDeviceImpl();

+ // TODO(miu): Some significant refactoring work is needed to support a

+ // separate WebRtcAudioDevice per render view. For now, here's a stub:

scherkus (not reviewing) 2012/10/18 01:56:28 as crogers@ mentions, filing + linking to a crbug.

miu 2012/10/18 03:27:26 Done. http://crbug.com/156535

+ static const int kUnknownRenderViewId = -1;

+ audio_device_ = new WebRtcAudioDeviceImpl(kUnknownRenderViewId);

scoped_refptr<webrtc::PeerConnectionFactoryInterface> factory(

webrtc::CreatePeerConnectionFactory(worker_thread_,

signaling_thread_,