Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: VLOG --> DVLOG in audio*renderer_host.cc Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_device_factory.h
diff --git a/content/renderer/media/audio_device_factory.h b/content/renderer/media/audio_device_factory.h
index e95e487e88a95acc4f97077ac84206cd864d7c2f..3127430826f0e2872168e1e3b4aff6df648e0b42 100644
--- a/content/renderer/media/audio_device_factory.h
+++ b/content/renderer/media/audio_device_factory.h
@@ -22,13 +22,19 @@ class CONTENT_EXPORT AudioDeviceFactory {
public:
// Creates an AudioRendererSink using the currently registered factory,
// or the default one if no factory is registered. Ownership of the returned
- // pointer will be passed to the caller.
- static media::AudioRendererSink* NewOutputDevice();
+ // pointer will be passed to the caller. |render_view_id| refers to the
+ // source of the output.
+ static media::AudioRendererSink* NewOutputDevice(
scherkus (not reviewing) 2012/10/18 01:56:28 nit: this appears to fit on one line
miu 2012/10/18 03:27:26 Done.
+ int render_view_id);
// TODO(henrika): Update AudioInputDevice to inherit from an interface
// similar to AudioRendererSink, but for input. Same for the callback
// interfaces.
- static media::AudioInputDevice* NewInputDevice();
+ // Creates an AudioInputDevice using the currently registered factory, or the
+ // default one if no factory is registered. Caller owns the returned object.
+ // |render_view_id| refers to the consumer of the input.
+ static media::AudioInputDevice* NewInputDevice(
+ int render_view_id);
protected:
AudioDeviceFactory();
@@ -38,8 +44,8 @@ class CONTENT_EXPORT AudioDeviceFactory {
// functions to provide alternate audio device implementations.
// If the return value of either of these function is NULL, we fall back
// on the default implementation.
- virtual media::AudioRendererSink* CreateOutputDevice() = 0;
- virtual media::AudioInputDevice* CreateInputDevice() = 0;
+ virtual media::AudioRendererSink* CreateOutputDevice(int render_view_id) = 0;
+ virtual media::AudioInputDevice* CreateInputDevice(int render_view_id) = 0;
private:
// The current globally registered factory. This is NULL when we should

Powered by Google App Engine
This is Rietveld 408576698