Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Side by Side Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/audio_renderer_mixer_manager.h" 5 #include "content/renderer/media/audio_renderer_mixer_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "content/renderer/media/audio_device_factory.h" 9 #include "content/renderer/media/audio_device_factory.h"
10 #include "media/base/audio_renderer_mixer.h" 10 #include "media/base/audio_renderer_mixer.h"
11 #include "media/base/audio_renderer_mixer_input.h" 11 #include "media/base/audio_renderer_mixer_input.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 AudioRendererMixerManager::AudioRendererMixerManager(int hardware_sample_rate, 15 AudioRendererMixerManager::AudioRendererMixerManager(int hardware_sample_rate,
16 int hardware_buffer_size) 16 int hardware_buffer_size)
17 : hardware_sample_rate_(hardware_sample_rate), 17 : hardware_sample_rate_(hardware_sample_rate),
18 hardware_buffer_size_(hardware_buffer_size) { 18 hardware_buffer_size_(hardware_buffer_size) {
19 } 19 }
20 20
21 AudioRendererMixerManager::~AudioRendererMixerManager() { 21 AudioRendererMixerManager::~AudioRendererMixerManager() {
22 DCHECK(mixers_.empty()); 22 DCHECK(mixers_.empty());
23 } 23 }
24 24
25 media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput() { 25 media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput(
26 int render_view_id) {
26 return new media::AudioRendererMixerInput( 27 return new media::AudioRendererMixerInput(
27 base::Bind( 28 base::Bind(
28 &AudioRendererMixerManager::GetMixer, base::Unretained(this)), 29 &AudioRendererMixerManager::GetMixer, base::Unretained(this),
30 render_view_id),
29 base::Bind( 31 base::Bind(
30 &AudioRendererMixerManager::RemoveMixer, base::Unretained(this))); 32 &AudioRendererMixerManager::RemoveMixer, base::Unretained(this),
33 render_view_id));
31 } 34 }
32 35
33 media::AudioRendererMixer* AudioRendererMixerManager::GetMixer( 36 media::AudioRendererMixer* AudioRendererMixerManager::GetMixer(
34 const media::AudioParameters& params) { 37 int render_view_id, const media::AudioParameters& params) {
35 base::AutoLock auto_lock(mixers_lock_); 38 base::AutoLock auto_lock(mixers_lock_);
36 39
37 AudioRendererMixerMap::iterator it = mixers_.find(params); 40 MixerByParamsMap& mixers_by_params = mixers_[render_view_id];
38 if (it != mixers_.end()) { 41 MixerByParamsMap::iterator it = mixers_by_params.find(params);
42 if (it != mixers_by_params.end()) {
39 it->second.ref_count++; 43 it->second.ref_count++;
40 return it->second.mixer; 44 return it->second.mixer;
41 } 45 }
42 46
43 // Create output parameters based on the audio hardware configuration for 47 // Create output parameters based on the audio hardware configuration for
44 // passing on to the output sink. Force to 16-bit output for now since we 48 // passing on to the output sink. Force to 16-bit output for now since we
45 // know that works well for WebAudio and WebRTC. 49 // know that works well for WebAudio and WebRTC.
46 media::AudioParameters output_params( 50 media::AudioParameters output_params(
47 media::AudioParameters::AUDIO_PCM_LOW_LATENCY, params.channel_layout(), 51 media::AudioParameters::AUDIO_PCM_LOW_LATENCY, params.channel_layout(),
48 hardware_sample_rate_, 16, hardware_buffer_size_); 52 hardware_sample_rate_, 16, hardware_buffer_size_);
49 53
50 media::AudioRendererMixer* mixer = new media::AudioRendererMixer( 54 media::AudioRendererMixer* mixer = new media::AudioRendererMixer(
51 params, output_params, AudioDeviceFactory::NewOutputDevice()); 55 params, output_params,
56 AudioDeviceFactory::NewOutputDevice(render_view_id));
52 57
53 AudioRendererMixerReference mixer_reference = { mixer, 1 }; 58 AudioRendererMixerReference mixer_reference = { mixer, 1 };
54 mixers_[params] = mixer_reference; 59 mixers_by_params[params] = mixer_reference;
55 return mixer; 60 return mixer;
56 } 61 }
57 62
58 void AudioRendererMixerManager::RemoveMixer( 63 void AudioRendererMixerManager::RemoveMixer(
59 const media::AudioParameters& params) { 64 int render_view_id, const media::AudioParameters& params) {
60 base::AutoLock auto_lock(mixers_lock_); 65 base::AutoLock auto_lock(mixers_lock_);
61 66
62 AudioRendererMixerMap::iterator it = mixers_.find(params); 67 AudioRendererMixerMap::iterator mixers_it = mixers_.find(render_view_id);
63 DCHECK(it != mixers_.end()); 68 DCHECK(mixers_it != mixers_.end());
69 MixerByParamsMap& mixers_by_params = mixers_it->second;
70 MixerByParamsMap::iterator it = mixers_by_params.find(params);
71 DCHECK(it != mixers_by_params.end());
64 72
65 // Only remove the mixer if AudioRendererMixerManager is the last owner. 73 // Only remove the mixer if AudioRendererMixerManager is the last owner.
66 it->second.ref_count--; 74 it->second.ref_count--;
67 if (it->second.ref_count == 0) { 75 if (it->second.ref_count == 0) {
68 delete it->second.mixer; 76 delete it->second.mixer;
69 mixers_.erase(it); 77 mixers_by_params.erase(it);
78 if (mixers_by_params.empty()) {
79 mixers_.erase(mixers_it);
80 }
70 } 81 }
71 } 82 }
72 83
73 } // namespace content 84 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698