Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(928)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/css/fontface-single-font-family-expected.txt
Issue
1116593003
:
Move font-family check to CSSPropertyParser (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: move check into CSSPropertyParser and add test
Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/css/fontface-single-font-family.html
LayoutTests/fast/css/fontface-single-font-family-expected.txt
Source/core/css/parser/CSSParserImpl.cpp
Source/core/css/parser/CSSPropertyParser.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« LayoutTests/fast/css/fontface-single-font-family.html
('k') |
Source/core/css/parser/CSSParserImpl.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
Test that @font-face has a single font-family-name.
2
3
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
4
5
6
PASS document.styleSheets[1].cssRules.length is 3
7
PASS document.styleSheets[1].cssRules[0].style.fontFamily is ""
8
PASS document.styleSheets[1].cssRules[1].style.fontFamily is "Ahem2"
9
PASS document.styleSheets[1].cssRules[2].style.fontFamily is ""
10
PASS successfullyParsed is true
11
12
TEST COMPLETE
13
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/css/fontface-single-font-family.html
('k') |
Source/core/css/parser/CSSParserImpl.cpp »
('j') |
no next file with comments »
Issue 1116593003: Move font-family check to CSSPropertyParser (Closed)
Created 5 years, 7 months ago by rwlbuis
Modified 5 years, 7 months ago
Reviewers: Timothy Loh
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0
This is Rietveld
408576698