Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1116563002: mac: Refer to NSEvent scrollingDeltaY as a method. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Refer to NSEvent scrollingDeltaY as a method. Prior to OSX 10.10, the declaration is a method. In OSX 10.10, the declaration became a property. For simplicity and consistent, always refer to scrollingDeltaY as a method. BUG=471823 Committed: https://crrev.com/8ea365b4d2f7747a765b531edc5c57ccf3ee317f Cr-Commit-Position: refs/heads/master@{#327437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
mark: Please review.
5 years, 7 months ago (2015-04-28 23:53:59 UTC) #2
Mark Mentovai
LGTM
5 years, 7 months ago (2015-04-29 00:37:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116563002/1
5 years, 7 months ago (2015-04-29 01:27:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 05:08:44 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 05:09:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ea365b4d2f7747a765b531edc5c57ccf3ee317f
Cr-Commit-Position: refs/heads/master@{#327437}

Powered by Google App Engine
This is Rietveld 408576698