Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 111653002: DevTools: Track async stacks on the corresponding execution context. (Closed)

Created:
7 years ago by aandrey
Modified:
7 years ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Track async stacks on the corresponding execution context. We should track async stacks separately for each execution context, so that async event IDs (like timer ID) from different execution contexts (e.g. iframes) should not mess with each other. BUG=272416 R=yurys, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163553

Patch Set 1 #

Patch Set 2 : no RefCounted #

Total comments: 3

Patch Set 3 : addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -63 lines) Patch
M Source/core/inspector/AsyncCallStackTracker.h View 3 chunks +13 lines, -9 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 2 3 chunks +77 lines, -33 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 11 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aandrey
7 years ago (2013-12-10 13:41:25 UTC) #1
pfeldman
https://codereview.chromium.org/111653002/diff/20001/Source/core/inspector/AsyncCallStackTracker.h File Source/core/inspector/AsyncCallStackTracker.h (right): https://codereview.chromium.org/111653002/diff/20001/Source/core/inspector/AsyncCallStackTracker.h#newcode76 Source/core/inspector/AsyncCallStackTracker.h:76: void didInstallTimer(ExecutionContext*, int timerId, bool singleShot, const ScriptValue& callFrames); ...
7 years ago (2013-12-10 15:31:34 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/111653002/diff/20001/Source/core/inspector/AsyncCallStackTracker.cpp File Source/core/inspector/AsyncCallStackTracker.cpp (right): https://codereview.chromium.org/111653002/diff/20001/Source/core/inspector/AsyncCallStackTracker.cpp#newcode53 Source/core/inspector/AsyncCallStackTracker.cpp:53: #ifdef DEBUG_ASYNC_CALLS_DEBUGGER_SUPPORT remove https://codereview.chromium.org/111653002/diff/20001/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/111653002/diff/20001/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode689 ...
7 years ago (2013-12-10 15:45:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/111653002/40001
7 years ago (2013-12-10 16:02:20 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-10 18:42:39 UTC) #5
Message was sent while issue was closed.
Change committed as 163553

Powered by Google App Engine
This is Rietveld 408576698