Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1116523003: slightly better docs for git instead of svn (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Slightly better docs for git instead of svn Not sure if this is 100% accurate, but better than all the SVN refs that are there now. R=iannucci@chromium.org, dpranke@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/0bb67471bca068996e15b56738fa4824dfa19de0

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M docs/Hacking.md View 1 2 chunks +10 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 7 months ago (2015-04-29 00:45:23 UTC) #1
iannucci
fwiw, lgtm
5 years, 7 months ago (2015-04-29 00:48:06 UTC) #3
scottmg
On 2015/04/29 00:48:06, iannucci wrote: > fwiw, lgtm good enough for me!
5 years, 7 months ago (2015-04-29 00:49:54 UTC) #4
scottmg
Committed patchset #2 (id:20001) manually as 0bb67471bca068996e15b56738fa4824dfa19de0 (presubmit successful).
5 years, 7 months ago (2015-04-29 00:50:02 UTC) #5
Dirk Pranke
5 years, 7 months ago (2015-04-29 01:06:31 UTC) #6
Message was sent while issue was closed.
lgtm. I have a patch to add a 'fetch' recipe for gyp somewhere, but this is fine
in the meantime.

Thanks for working on this; it was on my to-do list but I hadn't gotten to it
yet.

Powered by Google App Engine
This is Rietveld 408576698