cc: Remove save/restore from DrawingDisplayItem::Raster.

cc: Remove save/restore from DrawingDisplayItem::Raster.

Skia already calls save/restore on the canvas.

BUG=

Committed: https://crrev.com/6ebd2b851d626870be2cb0cdc44daee5e058c10b
Cr-Commit-Position: refs/heads/master@{#327395}

[jbroman, 2015-04-28 21:45:29]

jbroman@chromium.org changed reviewers:
+ ajuma@chromium.org

[jbroman, 2015-04-28 21:45:29]

reed@ pointed out that this save/restore is unnecessary because Skia already
guarantees this.

[danakj, 2015-04-28 21:46:41]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-04-28 21:46:42]

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
File cc/resources/drawing_display_item.cc (left):

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
cc/resources/drawing_display_item.cc:29: canvas->save();
could you say this in a comment here?

[jbroman, 2015-04-28 21:48:16]

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
File cc/resources/drawing_display_item.cc (left):

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
cc/resources/drawing_display_item.cc:29: canvas->save();
On 2015/04/28 21:46:41, danakj wrote:
> could you say this in a comment here?

Done. Was debating whether I should.

[ajuma, 2015-04-28 21:48:50]

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
File cc/resources/drawing_display_item.cc (left):

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
cc/resources/drawing_display_item.cc:33: canvas->drawPicture(picture_.get());
Does drawPicture also guarantee save/restore?

[jbroman, 2015-04-28 21:55:33]

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
File cc/resources/drawing_display_item.cc (left):

https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
cc/resources/drawing_display_item.cc:33: canvas->drawPicture(picture_.get());
On 2015/04/28 21:48:50, ajuma wrote:
> Does drawPicture also guarantee save/restore?

Yes.

It always dispatches either to SkRecordDraw, which does (via
SkCanvas::drawPicture -> SkCanvas::onDrawPicture -> SkPicture::playback), the
usual path, or to GrRecordReplaceDraw (via SkCanvas::drawPicture ->
SkCanvas::onDrawPicture -> SkGpuDevice::EXPERIMENTAL_drawPicture).

[ajuma, 2015-04-28 21:58:21]

On 2015/04/28 21:55:33, jbroman wrote:
>
https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
> File cc/resources/drawing_display_item.cc (left):
> 
>
https://codereview.chromium.org/1116523002/diff/1/cc/resources/drawing_displa...
> cc/resources/drawing_display_item.cc:33: canvas->drawPicture(picture_.get());
> On 2015/04/28 21:48:50, ajuma wrote:
> > Does drawPicture also guarantee save/restore?
> 
> Yes.
> 
> It always dispatches either to SkRecordDraw, which does (via
> SkCanvas::drawPicture -> SkCanvas::onDrawPicture -> SkPicture::playback), the
> usual path, or to GrRecordReplaceDraw (via SkCanvas::drawPicture ->
> SkCanvas::onDrawPicture -> SkGpuDevice::EXPERIMENTAL_drawPicture).

lgtm

[jbroman, 2015-04-28 22:02:43]

The CQ bit was checked by jbroman@chromium.org

[danakj, 2015-04-28 22:04:31]

LGTM

[commit-bot: I haz the power, 2015-04-28 22:05:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116523002/20001

[commit-bot: I haz the power, 2015-04-29 00:05:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 00:06:14]

Patchset 2 (id:??) landed as
https://crrev.com/6ebd2b851d626870be2cb0cdc44daee5e058c10b
Cr-Commit-Position: refs/heads/master@{#327395}