Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1116493003: Revert of [Android] Remove more uses of android_commands from build/android/pylib. (Closed)

Created:
5 years, 7 months ago by aberent
Modified:
5 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Remove more uses of android_commands from build/android/pylib. (patchset #3 id:40001 of https://codereview.chromium.org/1105323002/) Reason for revert: Causes HostDriven_SigninTest.testManagedSignin to fail, and hence prevents rolls into Android downstream repository BUG=482406 Original issue's description: > [Android] Remove more uses of android_commands from build/android/pylib. > > BUG=267773 > > Committed: https://crrev.com/166b709fc6c8fefad72520473850ce15ffe45898 > Cr-Commit-Position: refs/heads/master@{#327402} TBR=perezju@chromium.org,mikecase@chromium.org,rnephew@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/6a02a61868b123ce8407d745c840ef623f2ef09c Cr-Commit-Position: refs/heads/master@{#327469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -179 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/base/base_test_runner.py View 1 chunk +4 lines, -5 lines 0 comments Download
M build/android/pylib/base/test_dispatcher.py View 6 chunks +15 lines, -5 lines 0 comments Download
M build/android/pylib/base/test_dispatcher_unittest.py View 10 chunks +19 lines, -36 lines 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 chunk +0 lines, -18 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 1 chunk +0 lines, -23 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 2 chunks +8 lines, -67 lines 0 comments Download
M build/android/pylib/perf/perf_control_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download
M build/android/pylib/perf/setup.py View 2 chunks +3 lines, -4 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 3 chunks +7 lines, -6 lines 0 comments Download
M build/android/test_runner.py View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aberent
Created Revert of [Android] Remove more uses of android_commands from build/android/pylib.
5 years, 7 months ago (2015-04-29 11:06:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116493003/1
5 years, 7 months ago (2015-04-29 11:07:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 11:08:04 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 11:08:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a02a61868b123ce8407d745c840ef623f2ef09c
Cr-Commit-Position: refs/heads/master@{#327469}

Powered by Google App Engine
This is Rietveld 408576698