Introduce NullVideoSink for test classes.

media/base/null_video_sink_unittest.cc

Index: media/base/null_video_sink_unittest.cc
diff --git a/media/base/null_video_sink_unittest.cc b/media/base/null_video_sink_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8f7db6945b79ceccb261ceed4517fbcadfd8e9e7
--- /dev/null
+++ b/media/base/null_video_sink_unittest.cc
@@ -0,0 +1,156 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/callback_helpers.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/test/simple_test_tick_clock.h"
+#include "media/base/null_video_sink.h"
+#include "media/base/test_helpers.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+using testing::DoAll;
+using testing::Return;
+
+namespace media {
+
+ACTION_P(RunClosure, closure) {
+  closure.Run();
+}
+
+class NullVideoSinkTest : public testing::Test,
+                          public VideoRendererSink::RenderCallback {
+ public:
+  NullVideoSinkTest() {
+    // Never use null TimeTicks since they have special connotations.
+    tick_clock_.Advance(base::TimeDelta::FromMicroseconds(12345));
+  }
+  ~NullVideoSinkTest() override {}
+
+  base::TimeDelta default_interval() const {
+    return base::TimeDelta::FromMilliseconds(25);
+  }
+
+  base::TimeTicks current_time() {
+    return tick_clock_.NowTicks();
+  }
+
+  base::TimeTicks current_interval_end() {
+    return tick_clock_.NowTicks() + default_interval();
+  }

[xhwang, 2015/04/28 23:12:07]

style nit: These are not getters and should use normal function name CamelCase
style.

[DaleCurtis, 2015/04/29 00:54:07]

Removed since they were only in one test.

+
+  scoped_ptr<NullVideoSink> ConstructSink(bool clockless,
+                                          base::TimeDelta interval) {
+    scoped_ptr<NullVideoSink> new_sink(new NullVideoSink(
+        clockless, interval,
+        base::Bind(&NullVideoSinkTest::FrameReceived, base::Unretained(this)),
+        message_loop_.task_runner()));
+    new_sink->set_tick_clock_for_testing(&tick_clock_);
+    return new_sink;

[xhwang, 2015/04/28 23:12:06]

.Pass()?

[DaleCurtis, 2015/04/29 00:54:07]

Not necessary in this case, it's automatically moved.

[xhwang, 2015/04/29 03:49:13]

Cool. TIL!

+  }
+
+  scoped_refptr<VideoFrame> CreateFrame(base::TimeDelta timestamp) {
+    const gfx::Size natural_size(8, 8);
+    return VideoFrame::CreateFrame(VideoFrame::YV12, natural_size,
+                                   gfx::Rect(natural_size), natural_size,
+                                   timestamp);
+  }
+
+  // VideoRendererSink::RenderCallback implementation.
+  MOCK_METHOD2(Render,
+               scoped_refptr<VideoFrame>(base::TimeTicks, base::TimeTicks));
+  MOCK_METHOD0(OnFrameDropped, void());
+
+  MOCK_METHOD1(FrameReceived, void(const scoped_refptr<VideoFrame>&));
+
+ protected:
+  base::MessageLoop message_loop_;
+  base::SimpleTestTickClock tick_clock_;
+
+  DISALLOW_COPY_AND_ASSIGN(NullVideoSinkTest);
+};
+
+
+TEST_F(NullVideoSinkTest, BasicFunctionality) {
+  scoped_ptr<NullVideoSink> sink = ConstructSink(false, default_interval());
+  scoped_refptr<VideoFrame> test_frame = CreateFrame(base::TimeDelta());
+
+  // The sink shouldn't have to be started to use the paint method.
+  EXPECT_CALL(*this, FrameReceived(test_frame));
+  sink->PaintFrameUsingOldRenderingPath(test_frame);
+
+  {
+    SCOPED_TRACE("Waiting for sink startup.");
+    sink->Start(this);
+    EXPECT_CALL(*this, Render(current_time(), current_interval_end()))
+        .WillOnce(Return(test_frame));
+    base::RunLoop run_loop;
+    EXPECT_CALL(*this, FrameReceived(test_frame))
+        .WillOnce(RunClosure(run_loop.QuitClosure()));
+    run_loop.Run();
+  }
+
+  // A second call returning the same frame should not result in a new call to
+  // FrameReceived().
+  {
+    SCOPED_TRACE("Waiting for second render call.");
+    WaitableMessageLoopEvent event;
+    EXPECT_CALL(*this, Render(_, _))
+        .WillOnce(Return(test_frame))
+        .WillOnce(Return(nullptr));
+    EXPECT_CALL(*this, FrameReceived(test_frame)).Times(0);
+    EXPECT_CALL(*this, FrameReceived(scoped_refptr<VideoFrame>()))
+        .WillOnce(RunClosure(event.GetClosure()));
+    event.RunAndWait();
+  }
+
+  {
+    SCOPED_TRACE("Waiting for stop event.");
+    WaitableMessageLoopEvent event;
+    sink->set_stop_callback(event.GetClosure());
+    sink->Stop();
+    event.RunAndWait();
+  }
+}
+
+TEST_F(NullVideoSinkTest, ClocklessFunctionality) {
+  // Construct the sink with a huge interval, it should still complete quickly.
+  const base::TimeDelta interval = base::TimeDelta::FromSeconds(10);
+  scoped_ptr<NullVideoSink> sink = ConstructSink(true, interval);
+
+  scoped_refptr<VideoFrame> test_frame = CreateFrame(base::TimeDelta());
+  sink->Start(this);
+
+  EXPECT_CALL(*this, FrameReceived(test_frame)).Times(1);
+  EXPECT_CALL(*this, FrameReceived(scoped_refptr<VideoFrame>())).Times(1);
+
+  const int kTestRuns = 6;
+  const base::TimeTicks now = base::TimeTicks::Now();
+  const base::TimeTicks current_time = tick_clock_.NowTicks();
+
+  // Use a RunLoop instead of WaitableMessageLoopEvent() since it will only quit
+  // the loop when it's idle, instead of quitting immediately which is required
+  // when clockless playback is enabled (otherwise the loop is never idle).
+  base::RunLoop run_loop;
+  for (int i = 0; i < kTestRuns; ++i) {
+    if (i < kTestRuns - 1) {
+      EXPECT_CALL(*this, Render(current_time + i * interval,
+                                current_time + (i + 1) * interval))
+          .WillOnce(Return(test_frame));
+    } else {
+      EXPECT_CALL(*this, Render(current_time + i * interval,
+                                current_time + (i + 1) * interval))
+          .WillOnce(DoAll(RunClosure(run_loop.QuitClosure()), Return(nullptr)));
+    }
+  }
+
+  run_loop.Run();
+  ASSERT_LT(base::TimeTicks::Now() - now, kTestRuns * interval);
+  sink->Stop();
+}
+

[xhwang, 2015/04/28 23:12:06]

Is it interesting to test the case where Render() takes some time that we have
to skip a render interval?

[DaleCurtis, 2015/04/29 00:54:07]

Not particularly in this case, it was more important for audio. It's also hard
to test given performance tolerances on the bot. I.e. we'd end up using a sleep
during Render() to stall the callback, but who knows what the result of that
will be on a bot. It could sleep for 1 cycle or many.

[xhwang, 2015/04/29 03:49:13]

Can you just call tick_clock_.Advance() in Render() to simulate the case that
Render() stalled callback?

+}