Introduce NullVideoSink for test classes.

media/base/null_video_sink.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[xhwang, 2015/04/28 23:12:06]

2015

[DaleCurtis, 2015/04/29 00:54:07]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/null_video_sink.h"
+
+#include "base/bind.h"
+#include "base/callback_helpers.h"
+#include "base/location.h"
+#include "base/single_thread_task_runner.h"
+
+namespace media {
+
+NullVideoSink::NullVideoSink(
+    bool clockless,
+    base::TimeDelta interval,
+    const NewFrameCB& new_frame_cb,
+    const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
+    : clockless_(clockless),
+      interval_(interval),
+      new_frame_cb_(new_frame_cb),
+      task_runner_(task_runner),
+      started_(false),
+      callback_(nullptr),
+      tick_clock_(&default_tick_clock_) {
+}
+
+NullVideoSink::~NullVideoSink() {
+  DCHECK(!started_);
+}
+
+void NullVideoSink::Start(RenderCallback* callback) {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  DCHECK(!started_);
+  callback_ = callback;
+  started_ = true;
+  last_now_ = current_render_time_ = tick_clock_->NowTicks();
+  cancelable_worker_.Reset(
+      base::Bind(&NullVideoSink::CallRender, base::Unretained(this)));
+  task_runner_->PostTask(FROM_HERE, cancelable_worker_.callback());
+}
+
+void NullVideoSink::Stop() {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  cancelable_worker_.Cancel();
+  started_ = false;
+  if (!stop_cb_.is_null())
+    base::ResetAndReturn(&stop_cb_).Run();
+}
+
+void NullVideoSink::CallRender() {
+  DCHECK(task_runner_->BelongsToCurrentThread());
+  DCHECK(started_);
+
+  const base::TimeTicks end_of_interval = current_render_time_ + interval_;
+  DVLOG(2) << "NullVideoSink::Render(" << current_render_time_.ToInternalValue()

[xhwang, 2015/04/28 23:12:06]

s/Render/CallRender? This doesn't necessarily trigger a callback_->Render()
call...

[DaleCurtis, 2015/04/29 00:54:07]

Just going to remove, it was really for debugging anyways.

+           << ", " << end_of_interval.ToInternalValue() << ")";
+
+  if (current_render_time_ > pause_end_time_) {
+    scoped_refptr<VideoFrame> new_frame =
+        callback_->Render(current_render_time_, end_of_interval);
+    const bool is_new_frame = new_frame != last_frame_;
+    last_frame_ = new_frame;
+    if (is_new_frame)
+      new_frame_cb_.Run(new_frame);
+  }
+
+  current_render_time_ += interval_;
+
+  if (clockless_) {
+    task_runner_->PostTask(FROM_HERE, cancelable_worker_.callback());
+    return;
+  }
+
+  // Recompute now to compensate for the cost of Render().
+  const base::TimeTicks now = tick_clock_->NowTicks();
+  base::TimeDelta delay = current_render_time_ - now;
+
+  // If we're behind, find the next nearest on time interval.
+  if (delay < base::TimeDelta())
+    delay += interval_ * (-delay / interval_ + 1);

[xhwang, 2015/04/28 23:12:06]

IIUIC, this translates to:
   delay += interval_ * (-delay / interval_) + interval_;
=> new_delay = delay + interval_ * (-delay / interval_) + interval_;
=> new_delay = delay - delay + interval_ ;
=> new_delay = interval_

Is this what you want? It doesn't seem to give us the next interval starting
from current_render_time_...

[DaleCurtis, 2015/04/29 00:54:07]

That's not quite true since this is integer math and the parenthesis force
(-delay/interval_) to be computed first. Consider:

interval = 10
now = 12;
delay == (10 - 12) == -2
=> delay += 10 * (2 / 10 + 1)
=> delay += 10 * (0 + 1)
=> new_delay = -2 + 10 = 8

now = 22;
delay == (10 - 22) == -12
=> delay += 10 * (12 / 10 + 1)
=> delay += 10 * (1 + 1)
=> new_delay = -12 + 2 * 10 == 8

I think this is the same as "delay = interval - (-delay % interval)" if you
prefer that instead.

[xhwang, 2015/04/29 03:49:13]

Ah, I see. Sorry for my ignorance :)

Just an extra comment on the edge case:

now = 20;
delay == (10 - 20) == -10
=> delay += 10 * (10 / 10 + 1)
=> delay += 10 * (1 + 1)
=> new_delay = -10 + 2 * 10 == 10

But shouldn't the new_delay be 0 in this case?

[DaleCurtis, 2015/04/29 04:26:48]

It could go either way, since delay is 0, we may not be able to run right away
if other tasks are queued, so we have previously taken the safe route to wait
until the next callback.

+  current_render_time_ = now + delay;
+
+  // The tick clock is frozen in this case, so clamp delay to the interval time.
+  // We still want the interval passed to Render() to grow, but we also don't
+  // want the delay used here to increase slowly over time.
+  if (last_now_ == now && delay > interval_)
+    delay = interval_;
+  last_now_ = now;
+
+  task_runner_->PostDelayedTask(FROM_HERE, cancelable_worker_.callback(),
+                                delay);
+}
+
+void NullVideoSink::PaintFrameUsingOldRenderingPath(
+    const scoped_refptr<VideoFrame>& frame) {
+  new_frame_cb_.Run(frame);
+}
+
+}  // namespace media